Move to shimmed codec adapter interface #3999
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbaluta
requested review from
cujomalainey,
lbetlej,
lgirdwood,
mmaka1,
mrajwa and
plbossart
as code owners
Collaborator
Author
|
This is mostly done, we need to set different UUID for waves/cadences/passthrough codecs and update the topology files. Based on @cujomalainey work! |
dbaluta
changed the title
Collaborator
Author
|
@cujomalainey @mrajwa @lgirdwood this is ready to be merged. I have added different UUIDs for Waves / passtrhough and kept the old codec_adapter UUID for Cadence codecs. @stolx can you please test this with Waves? You need to use the new UUID as explained in the second commit. Tested this for cadence with mp3 / passthrough and works fine. |
Collaborator
|
These Quickbuild errors look relevant for a change: As usual they may be delayed by days so in case of force-pushes make sure you check the timestamp and SHA1 I recently added to the build and quoted above. |
In order to act as a stand in layer for codecs going forward we need to not log using our comp_driver as that will be removed in the future. Instead we need to log using the context of comp_dev. This commit also reduces the verbosity of a lot of the traces and increases a few. Signed-off-by: Curtis Malainey <cujomalainey@chromium.org>
This commit strips the codec adapter as it is more of a library/layer for codecs to simplify their interface against rather than a component in and of itself. This gives each codec its own UUID solving the ID problem while opening an opertunity to register codecs directly for future multiplexing capabilities. Old UUID adapter used for codec_adapter is now used for Cadence codecs, and we add new UUIDs for passthrough and Waves codecs. Signed-off-by: Curtis Malainey <cujomalainey@chromium.org> Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
Each codec family is now having its own UUID. We keep the old
codec_adapter UUID to be used with Cadence family codecs.
All other codec families (e.g passthrough, waves) needs to use new
uuids.
The topology files will just need to define CA_UID macro.
e.g for waves codec, topology file should contain:
DECLARE_SOF_RT_UUID("Waves codec", waves_codec_uuid, 0xd944281a, 0xafe9,
0x4695, 0xa0, 0x43, 0xd7, 0xf6, 0x2b, 0x89, 0x53, 0x8e);
define(`CA_UUID', cadence_codec_uuid)
Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
Collaborator
Author
|
Thanks @marc-hb. Should be fixed now. |
lgirdwood
approved these changes
Apr 5, 2021
Member
|
Boot failure on one CML device, other CML boots so a DUT issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit strips the codec adapter as it is more of a
library/layer for codecs to simplify their interface against rather than a
component in and of itself. This gives each codec its own UUID solving the ID
problem while opening an opertunity to register codecs directly for
future multiplexing capabilities.
Signed-off-by: Curtis Malainey cujomalainey@chromium.org
Signed-off-by: Daniel Baluta daniel.baluta@nxp.com