Codec adapter cleanups and fixes #4000
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulstelian97
approved these changes
Apr 2, 2021
Collaborator
Author
|
SOFCI TEST |
lgirdwood
approved these changes
Apr 5, 2021
Member
|
@zrombel it looks like we are missing part of the CI results. Good to merge ? |
iuliana-prodan
approved these changes
Apr 6, 2021
Contributor
Collaborator
Author
There was a problem hiding this comment.
@iuliana-prodan Initially I added it only in this PR hoping it will get merge first. Anyhow, it doesn't matter that a commit is in 2 PR, git merge should easily take care of this.
Collaborator
Author
There was a problem hiding this comment.
@iuliana-prodan removed the commit from this PR, so that we eliminate any confusion.
Contributor
There was a problem hiding this comment.
I think that there might be some merge conflicts when applied on main. So, is safer this way.
processed field keeps the total number of processed bytes from the input buffer. We need to update this field also for the process_init operation. Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
local buffer is used to store the output of processing function. So, we need to compute its size based on codec_adapter output buffer not input buffer. For non-compressed processing the current code works because input and output buffer have equal sizes. Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
Member
|
CI showing a kernel timeout. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains some fixes from @cujomalainey in order to prepare #3999 and also
2 fixes discovered while debugging cadence codecs.