Skip to content

Conversation

@dbaluta
Copy link
Collaborator

@dbaluta dbaluta commented Apr 28, 2021

i.MX8QXP / i.MX8QM have the same configuration w.r.t topology.
But since we firstly added support for 8qxp all the names use
8qxp and then for 8qm we just borrow the files but using the 8qxp
naming.

This sometimes might cause confusion. So, we group under the
umbrella of imx8 naming both i.mx8qxp and i.mx8qm.

Signed-off-by: Daniel Baluta daniel.baluta@nxp.com

i.MX8QXP / i.MX8QM have the same configuration w.r.t topology.
But since we firstly added support for 8qxp all the names use
8qxp and then for 8qm we just borrow the files but using the 8qxp
naming.

This sometimes might cause confusion. So, we group under the
umbrella of imx8 naming both i.mx8qxp and i.mx8qm.

Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
@dbaluta
Copy link
Collaborator Author

dbaluta commented Apr 28, 2021

@zrombel can you please check the installer/checktree task:

 # Update sof-apl-nocodec.tplg when adding or removing a default platform
diff -u tests/staging_sof_ref.txt /home/runner/work/sof/sof/installer/../installer-builds/staging_sof_tree.txt
# Check two random topologies are there
test -f staging/sof-tplg/sof-apl-nocodec.tplg
test -f staging/sof-tplg/sof-imx8qxp-nocodec.tplg

Since we now changed the name of topologies it can no longer find them. It looks like it expects to find some predefined topology names.

@dbaluta dbaluta added this to the v1.8 milestone Apr 28, 2021
@iuliana-prodan
Copy link
Contributor

iuliana-prodan commented Apr 28, 2021

@dbaluta Totally agree with this patch, but we need a corresponding one in Linux for the dts, otherwise will have no topology to load.
Later edit: I just saw the dts patch on our internal tree :)

@lgirdwood lgirdwood merged commit 5ca0e9b into thesofproject:main Apr 28, 2021
@marc-hb
Copy link
Collaborator

marc-hb commented Apr 28, 2021

This broke the installer test. Please extend this search/replace to the installer/GNUmakefile.
git grep imx8qxp is your friend.

Cc: @ranj063 , @fredoh9 who noticed the breakage.

@marc-hb
Copy link
Collaborator

marc-hb commented Apr 28, 2021

@zrombel can you please check the installer/checktree task:

No need for @zrombel 's magic QuickBuild powers here, this is just a simple github action / very small script. You can copy/paste the commands run by github to reproduce:

make -C installer
make -C installer checktree

EDIT: to remove some platforms check installer/README

@dbaluta
Copy link
Collaborator Author

dbaluta commented Apr 29, 2021

Hi @marc-hb thanks for pointing this out. Fixed with #4116

@lgirdwood
Copy link
Member

This broke the installer test. Please extend this search/replace to the installer/GNUmakefile.
git grep imx8qxp is your friend.

Cc: @ranj063 , @fredoh9 who noticed the breakage.

Sounds like we need this test in CI ?

@dbaluta
Copy link
Collaborator Author

dbaluta commented Apr 29, 2021

@lgirdwood this is already in CI. It is the Job named checktree. In my comments above I mentioned that it looks to be broken but I didn't know how to fix. So @marc-hb pointed my in the right direction.

@iuliana-prodan
Copy link
Contributor

@lgirdwood since we are talking about CI - where can we find out the tests run by CI?
Like, for example, 14_04_TestDemuxSynchronizedCapture48000Hz24b32b4ch, from PR_REGRESSION.

@lgirdwood
Copy link
Member

@dbaluta thanks got you - I must have missed that in the report.
@iuliana-prodan I think we have to ask @kkarask and @wszypelt

@kkarask
Copy link

kkarask commented Apr 29, 2021

@iuliana-prodan Tests are on internal Intel repo.
Topology from this test:

       pipe_plb
    +-------------------------------+
    | +------+   +------+   +-----+ |                                                 +------+
    | | Host |-->| Buff |-->| Dai |-------------------------------------------------->| SSPx |
    | +------+   +------+   +-----+ |                                                 +------+
    +-------------------------------+                                                    |
                                                                                         |
                                                                                         |
        pipe_cap                                                                         |
    +----------------------------------------------------------------------------+       |
    | +-------+   +------+   +-----+   +------+   +-------+   +------+   +-----+ |    +------+
    | | Host1 |<--| Buff |<--| Vol |<--| Buff |<--| DeMux |<--| Buff |<--| Dai |<-----| SSPx |
    | +-------+   +------+   +-----+   +------+   +-------+   +------+   +-----+ |    +------+
    +-------------------------------------------------|--------------------------+
                                                      |
        pipe_cap                                      |
    +-------------------------------------------+     |
    | +-------+   +------+   +-----+   +------+ |     |
    | | Host2 |<--| Buff |<--| Vol |<--| Buff |<------+
    | +-------+   +------+   +-----+   +------+ |
    +-------------------------------------------+

@iuliana-prodan
Copy link
Contributor

@kkarask This topology is also in Intel's internal repo or is from SOF repo (maybe one from here)?

Thank you!

@wszypelt
Copy link

@iuliana-prodan
Sorry, but this topology only exists in Intel's internal repository.

@lgirdwood
Copy link
Member

@iuliana-prodan
Sorry, but this topology only exists in Intel's internal repository.

Hmm, I think all topologies used by CI to test features should be upstream otherwise it's difficult for developers to re-test on any failures.
@marc-hb @aiChaoSONG - how many Jenkins topologies are not upstream ?
@zrombel @kkarask @wszypelt - same question for internal CI ?

@wszypelt btw, you should have a SOF project invite in your mailbox (maybe it's in SPAM folder).

@zrombel
Copy link

zrombel commented Apr 30, 2021

@lgirdwood Python test do not use topologies defined in m4 file. Python tests are focusing on testing specific functionalities of FW and its components, they mimic driver by sending IPCs on its own and create topology dynamically depending on test case scenario. So I don't really se how to upstream those topologies.

@lgirdwood
Copy link
Member

@lgirdwood Python test do not use topologies defined in m4 file. Python tests are focusing on testing specific functionalities of FW and its components, they mimic driver by sending IPCs on its own and create topology dynamically depending on test case scenario. So I don't really se how to upstream those topologies.

ok, got you - so this will need someone from python tool to support any queries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants