-
Notifications
You must be signed in to change notification settings - Fork 349
topology: Use generic name for 8qxp/8qm #4111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
i.MX8QXP / i.MX8QM have the same configuration w.r.t topology. But since we firstly added support for 8qxp all the names use 8qxp and then for 8qm we just borrow the files but using the 8qxp naming. This sometimes might cause confusion. So, we group under the umbrella of imx8 naming both i.mx8qxp and i.mx8qm. Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
|
@zrombel can you please check the installer/checktree task: Since we now changed the name of topologies it can no longer find them. It looks like it expects to find some predefined topology names. |
|
@dbaluta Totally agree with this patch, but we need a corresponding one in Linux for the dts, otherwise will have no topology to load. |
No need for @zrombel 's magic QuickBuild powers here, this is just a simple github action / very small script. You can copy/paste the commands run by github to reproduce: EDIT: to remove some platforms check |
|
@lgirdwood this is already in CI. It is the Job named |
|
@lgirdwood since we are talking about CI - where can we find out the tests run by CI? |
|
@dbaluta thanks got you - I must have missed that in the report. |
|
@iuliana-prodan Tests are on internal Intel repo. |
|
@iuliana-prodan |
Hmm, I think all topologies used by CI to test features should be upstream otherwise it's difficult for developers to re-test on any failures. @wszypelt btw, you should have a SOF project invite in your mailbox (maybe it's in SPAM folder). |
|
@lgirdwood Python test do not use topologies defined in m4 file. Python tests are focusing on testing specific functionalities of FW and its components, they mimic driver by sending IPCs on its own and create topology dynamically depending on test case scenario. So I don't really se how to upstream those topologies. |
ok, got you - so this will need someone from python tool to support any queries. |
i.MX8QXP / i.MX8QM have the same configuration w.r.t topology.
But since we firstly added support for 8qxp all the names use
8qxp and then for 8qm we just borrow the files but using the 8qxp
naming.
This sometimes might cause confusion. So, we group under the
umbrella of imx8 naming both i.mx8qxp and i.mx8qm.
Signed-off-by: Daniel Baluta daniel.baluta@nxp.com