installer: Fix installer test #4116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbaluta
requested review from
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
After commit 5ca0e9b ("topology: Use generic name for 8qxp/8qm") installer test is broken as we also need to update the i.MX topology with the new naming. So, fix this by replacing imx8qxp naming with imx8. But while we are at it choose a better (more relevant) random topology, sof-imx8-wm8960.tplg instead of sof-imx8-nodec.tplg. Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
dbaluta
requested review from
ViorelSuman,
iuliana-prodan,
marc-hb and
paulstelian97
This was referenced Apr 29, 2021
paulstelian97
approved these changes
Apr 29, 2021
marc-hb
approved these changes
Apr 29, 2021
iuliana-prodan
approved these changes
Apr 29, 2021
Member
|
CI showing an unrelated known issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After commit 5ca0e9b ("topology: Use generic name for 8qxp/8qm")
installer test is broken as we also need to update the check tree
topologies to the new naming.
So, fix this by replacing imx8qxp naming with imx8. But while we are at
it choose a better random topology, sof-imx8-wm8960.tplg instead of
sof-imx8-nodec.tplg
Signed-off-by: Daniel Baluta daniel.baluta@nxp.com