-
Notifications
You must be signed in to change notification settings - Fork 349
topology: sof-glk-da7219: add support for cs42l42 #4134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Backport #4121 to GLK production branch |
|
the change is fine, but I am not sure the 'glk production branch' is actually maintained by anyone. Shouldn't those devices transition to the regular 'stable' branches after the initial release? I don't think anyone has a burning desire to keep maintaining one branch per device, that's quickly going to be problematic. |
|
@plbossart i agree that is the plan long term once we begin kernel uprevs, but these devices are still pinned at 4.14 and we are getting new codec support so I think for the sake of handling ABI changes, I think merging to this branch is probably the best solution for integration BUT it should land on main first. |
ok, it's already on main, I wasn't sure who maintains this 'glk-012-stable' branch. it's not really stable by any stretch of imagination... |
|
@slawblauciak are you to merge into glk-012 ? |
plbossart
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have to take back my approval since this is not the same patch as what was submitted to the SOF main branch, and I have no idea how this solution might work without the 10ms delay.
Add support for cs42l42 running on GLK boards. Signed-off-by: Brent Lu <brent.lu@intel.com>
|
The 10ms delay will be no longer needed since COE team is working on enabling bclk earlier in hw_params. I will update the commit message. |
plbossart
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, it was meant to be #4249 since you are requesting a merge into a product branch, not main. |
|
@plbossart probably best for you to also merge FW if you need to orchestrate between kernel, FW and topologies. |
Actually I don't even think the kernel PR is required for testing since it does nothing other than exposing bitfields we don't use. |
|
I thins we can drop this PR and use #4249 instead. Thanks. |
Add support for cs42l42 running on GLK boards. There is a 10 ms BCLK
delay in the master branch version to avoid the noise on TX path.
However, this feature is not supported on GLK production branch yet so
we remove it for now.
Signed-off-by: Brent Lu brent.lu@intel.com