Skip to content

Conversation

@brentlu
Copy link
Contributor

@brentlu brentlu commented Jun 15, 2021

Changing SSP2 configuration to use 24-bit sample bitwidth.

Signed-off-by: Brent Lu brent.lu@intel.com

Copy link
Member

@lgirdwood lgirdwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but will wait on @plbossart inputs.

@plbossart
Copy link
Member

It's good but this will conflicts with the PR #4288 which should go in first @brentlu

@lgirdwood
Copy link
Member

@plbossart do you mind if this is merged after conflict fixed before early BCLK ? Looks like we still have an open for BCLK. @brentlu can you fix conflict.

@plbossart
Copy link
Member

@plbossart do you mind if this is merged after conflict fixed before early BCLK ? Looks like we still have an open for BCLK. @brentlu can you fix conflict.

I don't have time to fix anything related to SSP at this point. If a conflict is generated someone else needs to take over this PR.

Changing sample depth of SSP2 to 24 bits for better dynamic range.

Signed-off-by: Brent Lu <brent.lu@intel.com>
@brentlu
Copy link
Contributor Author

brentlu commented Jun 29, 2021

Conflict has been resolved but @bardliao will need to rebase his branch for #4391 after this PR is merged

@lgirdwood lgirdwood merged commit 8c863f4 into thesofproject:main Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants