zephyr: add notifier_register(ipc_send_queued_msg) in task_main_start() #4428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... and rename some parameter names. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Fixes thesofproject#4356 In XTOS SOF, ipc_send_queued_msg() is run by task_main_primary_core(), the initialization of which has a hard and circular dependency with the initialization of the EDF scheduler. This EDF scheduler is not part of Zephyr. Because of the circular dependency it does not seem possible (nor desirable?) to refactor this code and make it compatible with Zephyr. So schedule ipc_send_queued_msg() differently in Zephyr: using a notifier triggered by the periodic Low Latency scheduler. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
marc-hb
force-pushed
the
ipc-queue-zephyr
branch
from
9183a64 to
ba6e208
Compare
marc-hb
requested review from
andyross,
iuliana-prodan,
kv2019i,
lgirdwood and
lyakh
Collaborator
Author
|
alsabat noise in https://sof-ci.01.org/sofpr/PR4428/build9523/devicetest/?model=CML_SKU0955_HDA&testcase=check-alsabat-headset-playback can't be related, everything else is green |
marc-hb
requested review from
dbaluta,
lbetlej,
mmaka1 and
plbossart
as code owners
lgirdwood
approved these changes
Jun 29, 2021
| /* init pipeline position offsets */ | ||
| pipeline_posn_init(sof); | ||
|
|
||
| (void)notifier_register(NULL, scheduler_get_data(SOF_SCHEDULE_LL_TIMER), |
Member
There was a problem hiding this comment.
Can we have a comment here stating the long term solution so everyone knows this will be temporary. This can be another PR, feel free to create a feature for this too.
Member
|
Alsabat showing some DUT clock drift wrt testing PC. |
marc-hb
added a commit
to marc-hb/sof
that referenced
this pull request
Jul 3, 2021
As requested in previous PR thesofproject#4428 Signed-off-by: Marc Herbert <marc.herbert@intel.com>
lgirdwood
pushed a commit
that referenced
this pull request
Jul 7, 2021
As requested in previous PR #4428 Signed-off-by: Marc Herbert <marc.herbert@intel.com>
ranj063
pushed a commit
to ranj063/sof
that referenced
this pull request
Jul 16, 2021
As requested in previous PR thesofproject#4428 Signed-off-by: Marc Herbert <marc.herbert@intel.com>
lgirdwood
pushed a commit
that referenced
this pull request
Jul 16, 2021
As requested in previous PR #4428 Signed-off-by: Marc Herbert <marc.herbert@intel.com>
This was referenced Jul 26, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the zephyr part of #4356
In XTOS SOF, ipc_send_queued_msg() is run by task_main_primary_core(),
the initialization of which has a hard and circular dependency with the
initialization of the EDF scheduler. This EDF scheduler is not part of
Zephyr. Because of the circular dependency it does not seem
possible (nor desirable?) to refactor this code and make it compatible
with Zephyr. So schedule ipc_send_queued_msg() differently in Zephyr:
using a notifier triggered by the periodic Low Latency scheduler.
Signed-off-by: Marc Herbert marc.herbert@intel.com
Not related to this PR but if you're curious about
NOTIFIER_ID_LL_POST_RUNfind information in #4430