cavs: pm: improve PM_RUNTIME_HOST_DMA_L1 documentation #4430
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reword doxygen comments and change the private helper function names to better reflect the actual implementation. No functional change. The PM_RUNTIME_HOST_DMA_L1 resource is used to coordinate host DMA users, so that DMI link is kept in L1 until all users are ready to activate the link. This is a bit unusual usage of runtime-pm interface in that a 'put on a resource' triggers transition to higher power state, so this deserves some more documentation. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
kv2019i
requested review from
dbaluta,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
Collaborator
|
thanks @kv2019i , this was incredibly confusing indeed. So |
Collaborator
|
Also confused by this: So "enable" and "active" are opposite of each other, correct? https://thesofproject.github.io/latest/developer_guides/firmware/pm-runtime/pm-dsp-core.html Power management = the land of double and triple negations. |
lgirdwood
approved these changes
Jun 29, 2021
Member
|
CI is known issue with kernel suspend. |
Collaborator
|
Additional comments in #4441 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reword doxygen comments and change the private helper function
names to better reflect the actual implementation. No functional
change.
The PM_RUNTIME_HOST_DMA_L1 resource is used to coordinate host DMA
users, so that DMI link is kept in L1 until all users are ready to
activate the link. This is a bit unusual usage of runtime-pm interface
in that a 'put on a resource' triggers transition to higher power state,
so this deserves some more documentation.
Signed-off-by: Kai Vehmanen kai.vehmanen@linux.intel.com