host: trace: revert host traces to fprintf #548
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkokoszx
force-pushed
the
revert-host-traces
branch
3 times, most recently
from
bea10b4 to
4196244
Compare
Collaborator
|
Can one of the admins verify this patch? |
Contributor
|
SOFCI TEST |
Member
|
@bkokoszx can you check the travis CI, lost of build errors for host. Btw, did you run the host build all script ? |
Collaborator
Author
|
@lgirdwood |
bkokoszx
force-pushed
the
revert-host-traces
branch
2 times, most recently
from
fea1fd5 to
1a315fb
Compare
bkokoszx
force-pushed
the
revert-host-traces
branch
5 times, most recently
from
35509e7 to
bdde0d8
Compare
mwierzbix
suggested changes
Nov 8, 2018
Contributor
mwierzbix
left a comment
mwierzbix
left a comment
There was a problem hiding this comment.
Nice solution but please do fix whitespace changes.
bkokoszx
force-pushed
the
revert-host-traces
branch
3 times, most recently
from
bfdd7a3 to
838184e
Compare
mwierzbix
approved these changes
Nov 8, 2018
mwierzbix
suggested changes
Nov 8, 2018
bkokoszx
force-pushed
the
revert-host-traces
branch
2 times, most recently
from
6f0d1a4 to
a9c9dda
Compare
Host doesn't use trace mechanism - I've reverted all host traces to simple fprintf. Signed-off-by: Bartosz Kokoszko <bartoszx.kokoszko@linux.intel.com>
bkokoszx
force-pushed
the
revert-host-traces
branch
from
a9c9dda to
e69b42f
Compare
mwierzbix
approved these changes
Nov 8, 2018
Collaborator
Author
|
@lgirdwood |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Host doesn't use trace mechanism - I've reverted
all host traces to simple fprintf.
Signed-off-by: Bartosz Kokoszko bartoszx.kokoszko@linux.intel.com