logger: add firmware verification capability #118

bkokoszx · 2018-10-29T13:03:20Z

I've added two logger flags for firmware version verification:
-e - enables checking fw version with default file
-v ver_file - enables checking fw version with ver_file file

Signed-off-by: Bartosz Kokoszko bartoszx.kokoszko@linux.intel.com

lgirdwood · 2018-10-29T13:26:26Z

README

 -c			Set timestamp clock in MHz
+-e			Enable checking firmware version with default verification file 
+			"/sys/kernel/debug/sof/fw_version"
+-v ver_file		Enable checking firmware version with ver_file file, 


Version check be done by default, this option should optionally disable it. Btw, why do we need a file here ? I thought version would be added to ldc file and read from sysfs ?

As discussed in #111 we decided to introduce this feature in 2 stages, to allow for parallel implementation from FW and kernel sides and to ensure that behaviour doesn't break anything in case of misalignment.
After verification of proper behaviour we'll change it to enable verification by default.
The version file is there to allow custom path to file dumped by driver, as our diagnostic driver on Windows uses different path than kernel one.

lgirdwood

Also need to address the header file, this may be a day or so before submodules working so it may be worth while also adding the component names into logger e.g. VOLUME1.1, VOLUME1.0 etc.
This means we should be able to catch all updates with one PR rather than several.

lgirdwood · 2018-10-29T14:33:28Z

rmbox/sof/uapi/ipc.h

@@ -0,0 +1,1020 @@
+/*


Why are we duplicating this header ? @cujomalainey will be creating some git sub modules so we should have a local version of this header in the next day or so.

Ok, I will update including headers, when the submodules are ready

rmbox/rmbox.c

I've added two logger flags for firmware version verification: -e - enables checking fw version with default file -v ver_file - enables checking fw version with ver_file file Signed-off-by: Bartosz Kokoszko <bartoszx.kokoszko@linux.intel.com>

bkokoszx · 2018-11-05T10:59:22Z

@lgirdwood @akloniex @xiulipan
I've added also logging topology number capability due to thesofproject/sof#530.
I'm waiting for moving soft to sof in order to remove dependency between logger and fw.

lgirdwood

Minor change flagged by github. Btw any chance you paste some example output in the commit message to show improvement.

lgirdwood · 2018-11-05T15:52:49Z

rmbox/sof/uapi/logging.h

 } __attribute__((__packed__));

-#endif //#ifndef __INCLUDE_LOGGING__
+#endif //#ifndef __INCLUDE_LOGGING__


Need newline (github flags this automatically)

lgirdwood

Minor change flagged by github. Btw any chance you paste some example output in the commit message to show improvement.

bkokoszx · 2018-11-05T16:13:07Z

@lgirdwood I've updated github issue and commit message.

lgirdwood

Ok, is there any PRs for this driver or can both this and the FW patch now be merged ?

bkokoszx · 2018-11-06T09:00:11Z

@lgirdwood @xiulipan @akloniex
FW part: thesofproject/sof#530
Linux part: thesofproject/linux#222
Since checking fw version in logger is optional in my opinion there isn't necessity to wait
for kernel part.

bkokoszx · 2018-11-06T10:15:35Z

@lgirdwood
I've added also macro
#define uintptr_t uint32_t
to enforce using uintptr_t as 4 bytes value (as in fw).

lgirdwood · 2018-11-06T14:04:37Z

@lgirdwood
I've added also macro
#define uintptr_t uint32_t
to enforce using uintptr_t as 4 bytes value (as in fw).

@bkokoszx we can't redefine types as it will silently break other things.

Once fixed, can you submit FW PR to topic/abi branch (we will do all ABI updates in a single merge)

bkokoszx · 2018-11-07T11:05:59Z

@lgirdwood
To enforce building logger for 32 bit I should use gcc with -m32 flag, but
it requires gcc-multilib. Do you think we should use it or find another way?

lgirdwood · 2018-11-07T13:57:12Z

@bkokoszx We cant do this 32bit build either, host build trace should just revert to printf directly (so pointers are not needed to lookup anyway). i.e. host will not use the trace mechanism. You can use an #ifdef in trace.h to separate DSP trace from host trace if needed.

I've added printing component topology number (i.e. pipeline_id.component_id). If id's are not defined logger will not print any values. e.g.: CORE LEVEL COMP_ID TIMESTAMP ... 0 2 HOST 487048.229167 ... (not defined id's) 0 2 PIPE 1.3 591235.052083 ... (defined id's) Signed-off-by: Bartosz Kokoszko <bartoszx.kokoszko@linux.intel.com>

bkokoszx · 2018-11-08T09:12:15Z

@lgirdwood
I'm working on updating uapi here: thesofproject/sof#548

lgirdwood · 2018-11-08T11:01:16Z

@bkokoszx will be merging ABI kernel and FW updates today. Will do it all in one big update to minimize disruption.

bkokoszx · 2018-11-08T14:54:56Z

@lgirdwood
Uapi is updated due to thesofproject/sof#548

bkokoszx · 2018-11-09T09:51:20Z

@lgirdwood
Do you have any additional remarks?

bkokoszx mentioned this pull request Oct 29, 2018

logger - invalid filename length #111

Closed

lgirdwood suggested changes Oct 29, 2018

View reviewed changes

bkokoszx force-pushed the logger-fw-verification branch from 03616d0 to 8c63e0f Compare October 29, 2018 13:35

lgirdwood suggested changes Oct 29, 2018

View reviewed changes

bkokoszx force-pushed the logger-fw-verification branch 4 times, most recently from 84f03e1 to 5d29941 Compare November 2, 2018 08:33

bkokoszx force-pushed the logger-fw-verification branch from 5d29941 to c6546c3 Compare November 5, 2018 10:53

bkokoszx force-pushed the logger-fw-verification branch 2 times, most recently from adc634c to a5d628a Compare November 5, 2018 15:19

lgirdwood suggested changes Nov 5, 2018

View reviewed changes

bkokoszx force-pushed the logger-fw-verification branch 2 times, most recently from f8c8eea to 3ced9d3 Compare November 5, 2018 16:11

lgirdwood reviewed Nov 5, 2018

View reviewed changes

bkokoszx force-pushed the logger-fw-verification branch from 3ced9d3 to 1ecd8ca Compare November 6, 2018 10:06

bkokoszx force-pushed the logger-fw-verification branch from 1ecd8ca to c7002ae Compare November 7, 2018 13:09

akloniex mentioned this pull request Nov 8, 2018

Regression: sof-logger doesn't work with -t parameter thesofproject/sof#551

Closed

bkokoszx force-pushed the logger-fw-verification branch from c7002ae to 105b9b5 Compare November 8, 2018 09:10

lgirdwood merged commit 73c8a13 into thesofproject:master Nov 9, 2018

bkokoszx mentioned this pull request Nov 22, 2018

trace output should include component names from topology thesofproject/sof#508

Closed

logger: add firmware verification capability #118

logger: add firmware verification capability #118

Uh oh!

Conversation

bkokoszx commented Oct 29, 2018

Uh oh!

lgirdwood Oct 29, 2018

Choose a reason for hiding this comment

Uh oh!

akloniex Oct 29, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lgirdwood left a comment

Choose a reason for hiding this comment

Uh oh!

lgirdwood Oct 29, 2018

Choose a reason for hiding this comment

Uh oh!

bkokoszx Oct 29, 2018

Choose a reason for hiding this comment

Uh oh!

Uh oh!

bkokoszx commented Nov 5, 2018

Uh oh!

lgirdwood left a comment

Choose a reason for hiding this comment

Uh oh!

lgirdwood Nov 5, 2018

Choose a reason for hiding this comment

Uh oh!

lgirdwood left a comment

Choose a reason for hiding this comment

Uh oh!

bkokoszx commented Nov 5, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lgirdwood left a comment

Choose a reason for hiding this comment

Uh oh!

bkokoszx commented Nov 6, 2018

Uh oh!

bkokoszx commented Nov 6, 2018

Uh oh!

lgirdwood commented Nov 6, 2018

Uh oh!

bkokoszx commented Nov 7, 2018

Uh oh!

lgirdwood commented Nov 7, 2018

Uh oh!

bkokoszx commented Nov 8, 2018

Uh oh!

lgirdwood commented Nov 8, 2018

Uh oh!

bkokoszx commented Nov 8, 2018

Uh oh!

bkokoszx commented Nov 9, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

akloniex Oct 29, 2018 •

edited

Loading

bkokoszx commented Nov 5, 2018 •

edited

Loading