Skip to content

Conversation

@akloniex
Copy link
Member

@akloniex akloniex commented Nov 2, 2018

In reference to #508

@akloniex akloniex requested review from lgirdwood and mmaka1 November 2, 2018 17:55
@akloniex
Copy link
Member Author

akloniex commented Nov 2, 2018

@lgirdwood I'm aware of conflicts. Please review current progress on this subject, to ensure that we're on the right track before I go full on with changing all trace macros in our project.

Copy link
Member

@lgirdwood lgirdwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going in the right direction. Think we can make this a little more generic for other users too.

Copy link
Member

@lgirdwood lgirdwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akloniex Lets get all the pieces approved and CI build fixed before merging.

@akloniex
Copy link
Member Author

akloniex commented Nov 5, 2018

@lgirdwood Currently build fails on Travis while building host target, due to cast from pointer to uint32_t. As host is built with x64 architecture, this warning seems legit, but I don't know how to work around this.
I could trick the compiler to turn off compile-time type-checking, a.k.a. restore previous behaviour, but it feels like too big of a cost.
I would appreciate your input.

@lgirdwood
Copy link
Member

@akloniex you could use uintptr_t instead of uint32_t as the host versions of the trace macros just call printf directly anyway (i.e. we dont use logger on host).

2 arbitrary IDs may now be passed to specialized versions of
trace_event macro: trace_event_with_ids. Also optimized runtime
stack usage of _trace_event functions.

Signed-off-by: ArturX Kloniecki <arturx.kloniecki@linux.intel.com>
Implemented set of macros for pipelines to allow reporting of pipeline
and component IDs. Refactor all traces to provide useful, human readible
messages.

Signed-off-by: ArturX Kloniecki <arturx.kloniecki@linux.intel.com>
Signed-off-by: ArturX Kloniecki <arturx.kloniecki@linux.intel.com>
Signed-off-by: ArturX Kloniecki <arturx.kloniecki@linux.intel.com>
@mwierzbix
Copy link
Contributor

@lgirdwood @akloniex Yay, all the checks are green now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants