Skip to content

Conversation

@marc-hb
Copy link
Collaborator

@marc-hb marc-hb commented Mar 9, 2022

This reverts commit f1e6e1f which
accidentally changed the PLATFORM variable for the tgl-h argument,
from PLATFORM=tglh to PLATFORM=tgplp

This reverts commit f1e6e1f which
accidentally changed the PLATFORM variable for the tgl-h argument,
from PLATFORM=tglh to PLATFORM=tgplp
@keqiaozhang
Copy link
Collaborator

SOFCI TEST

@keqiaozhang
Copy link
Collaborator

Confirmed that this PR can fix the booting issue #5493 on TGL-H device.

@kv2019i kv2019i requested review from lgirdwood and lyakh March 9, 2022 06:51
@softwarecki
Copy link
Collaborator

In fact, it's my fault. Instead of reverting commit, I would suggest restoring platform split to tgl and tgl-h without breaking code formatting.

@lgirdwood
Copy link
Member

@softwarecki do you have a quick fix PR that can be merged ?

@softwarecki
Copy link
Collaborator

lgirdwood I will prepare it today

@marc-hb
Copy link
Collaborator Author

marc-hb commented Mar 9, 2022

lgirdwood will prepare it today

The daily test run starts in a couple of hours and this issue blocks ALL testing on some platforms. That's one reason why I submitted a quick revert, we need this fixed in the next couple hours whereas reviewing a better fix is likely to take longer (and can always be done later anywayt)

The other reason for a revert was to minimize git conflicts with any other work in progress internally.

@softwarecki
Copy link
Collaborator

I prepared PR #5501

@marc-hb marc-hb closed this Mar 9, 2022
@marc-hb marc-hb deleted the revert-tglh branch March 9, 2022 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants