Skip to content

Conversation

@softwarecki
Copy link
Collaborator

@softwarecki softwarecki commented Mar 9, 2022

Recent combination of tgl and tgl-h building resulted in use of an invalid defconfig file for tgl-h platform. This PR reverts that change.

Fixes #5493

@marc-hb
Copy link
Collaborator

marc-hb commented Mar 9, 2022

LGTM, can you please add a Fixes: f1e6e1fdd3b7ede771d1babd4106301639015091 reference? Make sure you run checkpatch because it's going to check the syntax of that.

Recent combination of tgl and tgl-h building resulted in use of an invalid
defconfig file for tgl-h platform. This commit reverts that change.

Fixes: f1e6e1f

Signed-off-by: Adrian Warecki <adrianx.warecki@intel.com>
@marc-hb
Copy link
Collaborator

marc-hb commented Mar 9, 2022

The only checkpatch warning is "line too long"

@marc-hb marc-hb added bug Something isn't working as expected P1 Blocker bugs or important features labels Mar 9, 2022
@marc-hb
Copy link
Collaborator

marc-hb commented Mar 9, 2022

Can someone merge this urgently before the next daily test run?

I looked at all failures in https://sof-ci.01.org/sofpr/PR5501/build12279/devicetest/ and they're all known issues already tracked in github. Some have incoming fixes. PR testing does not test TGL-H anyway (why this issue slipped in the first place).

Copy link
Collaborator

@kv2019i kv2019i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ranj063 ranj063 merged commit b9d9719 into thesofproject:main Mar 9, 2022
@softwarecki softwarecki deleted the build-script-fix branch March 17, 2022 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working as expected P1 Blocker bugs or important features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG][TGL-H] firmware failed to boot on TGL-H laptop

4 participants