Skip to content

[RTNR] Fix buffer size calculation #5541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lgirdwood merged 1 commit into from
Mar 30, 2022
Merged

[RTNR] Fix buffer size calculation #5541

lgirdwood merged 1 commit into from
Mar 30, 2022

Conversation

@MingJenTai
Copy link
Contributor

@MingJenTai MingJenTai commented Mar 15, 2022

This PR fixes the faulty calculation of component buffer size.

@MingJenTai MingJenTai force-pushed the main_fix_buffer_size_calculation branch from 237bd65 to ff5e668 Compare March 15, 2022 05:05
@lgirdwood
Copy link
Member

lgirdwood commented Mar 15, 2022

@MingJenTai I guess this needs a backport to adl-04 and tgl13 ?
@sathya-nujella @sathyap-chrome @mwasko fyi

lgirdwood
lgirdwood reviewed Mar 15, 2022
View reviewed changes
Copy link
Member

@lgirdwood lgirdwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MingJenTai forgot to say, can you say in the commit message how the buffer size should be calculated for RTNR.

@cujomalainey
Copy link
Contributor

cujomalainey commented Mar 15, 2022

Please also add my sign-off to the commit as this was a joint fix

@MingJenTai
[RTNR] Fix buffer size calculation
a2999d8 
The correct frame length should be calculated by
FRAME_LEN = SAMPLING_RATE * PERIODS / 1000000

The macro COMP_PERIOD_FRAMES does the thing.

Signed-off-by: Curtis Malainey <cujomalainey@chromium.org>
Signed-off-by: Ming Jen Tai <mingjen_tai@realtek.com>
@MingJenTai MingJenTai force-pushed the main_fix_buffer_size_calculation branch from ff5e668 to a2999d8 Compare March 16, 2022 00:46
@MingJenTai
Copy link
Contributor Author

MingJenTai commented Mar 16, 2022

@MingJenTai I guess this needs a backport to adl-04 and tgl13 ? @sathya-nujella @sathyap-chrome @mwasko fyi

Yes a backport to adl-04 is needed. But I am not sure if tgl13 is also needed.

@MingJenTai
Copy link
Contributor Author

MingJenTai commented Mar 16, 2022

@MingJenTai forgot to say, can you say in the commit message how the buffer size should be calculated for RTNR.

Added in the commit message, thanks!

@MingJenTai
Copy link
Contributor Author

MingJenTai commented Mar 16, 2022

Please also add my sign-off to the commit as this was a joint fix

Yes your sign-off is added in the commit message, thanks!

@lgirdwood
Copy link
Member

lgirdwood commented Mar 16, 2022

SOFCI TEST

@lgirdwood
Copy link
Member

lgirdwood commented Mar 16, 2022

Rerun CI, looks like CI was blocked.

@lgirdwood lgirdwood merged commit a5fd52e into thesofproject:main Mar 30, 2022
@cujomalainey
Copy link
Contributor

cujomalainey commented Mar 30, 2022

@MingJenTai please send to ald-004-drop-stable release branch

@MingJenTai
Copy link
Contributor Author

MingJenTai commented Mar 31, 2022

@MingJenTai please send to ald-004-drop-stable release branch

Done. Please check #5625

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lgirdwood lgirdwood lgirdwood approved these changes

@plbossart plbossart Awaiting requested review from plbossart

@mmaka1 mmaka1 Awaiting requested review from mmaka1

@lbetlej lbetlej Awaiting requested review from lbetlej

@dbaluta dbaluta Awaiting requested review from dbaluta

+1 more reviewer

@cujomalainey cujomalainey cujomalainey approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MingJenTai @lgirdwood @cujomalainey