Skip to content

Conversation

@MingJenTai
Copy link
Contributor

The correct frame length should be calculated by
FRAME_LEN = SAMPLING_RATE * PERIODS / 1000000

The macro COMP_PERIOD_FRAMES does the thing.

Signed-off-by: Curtis Malainey cujomalainey@chromium.org
Signed-off-by: Ming Jen Tai mingjen_tai@realtek.com

cherry-picked from a5fd52e

The correct frame length should be calculated by
FRAME_LEN = SAMPLING_RATE * PERIODS / 1000000

The macro COMP_PERIOD_FRAMES does the thing.

Signed-off-by: Curtis Malainey <cujomalainey@chromium.org>
Signed-off-by: Ming Jen Tai <mingjen_tai@realtek.com>

cherry-picked from a5fd52e
Copy link
Contributor

@cujomalainey cujomalainey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a direct cherry-pick of what landed on main, is there a reason why? a5fd52e

@MingJenTai MingJenTai changed the title Fix faulty calculation of RTNR component's buffer size. [RTNR] Fix buffer size calculation Apr 6, 2022
@MingJenTai
Copy link
Contributor Author

This is not a direct cherry-pick of what landed on main, is there a reason why? a5fd52e

Hi @cujomalainey,

It is the cherry-pick of main, but the title was modified. Changed it back to be the same as the PR on main. Thanks!

@cujomalainey
Copy link
Contributor

This is not a direct cherry-pick of what landed on main, is there a reason why? a5fd52e

Hi @cujomalainey,

It is the cherry-pick of main, but the title was modified. Changed it back to be the same as the PR on main. Thanks!

Hi MingJen,

The commit has not been updated, the commit should be direct cherry-pick with no modifications unless there is conflicts or a functionality issue

@MingJenTai
Copy link
Contributor Author

Hi @cujomalainey,

Created a new PR( #5649 ). Please check if it is OK now. Thanks.

Closing this one.

@MingJenTai MingJenTai closed this Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants