ipc4: refine reset state to fix audio player issue in windows #5548
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Progress bar of audio player disappears when it is dragged by mouse. In this case pipeline is first paused then reset.Driver checks the llp position in memory windows by node id. Driver can't find llp position since fw cleared node id. This patch reserves node id for pause-reset case and only reset llp position. The node_id will be cleared when dai is free. Signed-off-by: Rander Wang <rander.wang@intel.com>
RanderWang
requested review from
dbaluta,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
Member
|
@tmleman fyi |
RanderWang
changed the title
Progress bar of audio player disappears when it is dragged by mouse. In this case pipeline is first paused then reset, paused started again. Cd data is initialized when copier is created and will not be initialized again after reset operation, so we can't clear cd data in reset state, only reset stream position and used dai or host. Signed-off-by: Rander Wang <rander.wang@intel.com>
RanderWang
force-pushed
the
ipc4_llp_reset
branch
from
1f46cb3 to
a0fb7c4
Compare
tmleman
approved these changes
Mar 16, 2022
lgirdwood
approved these changes
Mar 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress bar of audio player disappears when it is dragged by
mouse. In this case pipeline is first paused then reset.Driver
checks the llp position in memory windows by node id. Driver
can't find llp position since fw cleared node id. This patch
reserves node id for pause-reset case and only reset llp position.
The node_id will be cleared when dai is free.
Signed-off-by: Rander Wang rander.wang@intel.com