Skip to content

ipc4: refine reset state to fix audio player issue in windows #5548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lgirdwood merged 2 commits into from
Mar 16, 2022
Merged

ipc4: refine reset state to fix audio player issue in windows #5548

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3edd603
ipc4: dai: reset llp position to 0 for dai_reset
RanderWang Mar 15, 2022
a0fb7c4
ipc4: copier: reserve cd data for reset state
RanderWang Mar 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/audio/copier.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -533,7 +533,6 @@ static int copier_reset(struct comp_dev *dev)
mailbox_sw_regs_write(cd->pipeline_reg_offset, &pipe_reg, sizeof(pipe_reg));
}

memset(cd, 0, sizeof(*cd));
comp_set_state(dev, COMP_TRIGGER_RESET);

return ret;
Expand Down
7 changes: 6 additions & 1 deletion src/ipc/ipc4/dai.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,8 +186,13 @@ void dai_dma_release(struct comp_dev *dev)

get_llp_reg_info(dd, &node_id, &llp_reg_offset);
if (node_id) {
/* clear memory window */
/* reset llp position to 0 in memory window for reset state.
* clear node id and llp position to 0 when dai is free
*/
memset_s(&slot, sizeof(slot), 0, sizeof(slot));
if (dev->state == COMP_STATE_PAUSED)
slot.node_id = node_id;

mailbox_sw_regs_write(llp_reg_offset, &slot, sizeof(slot));
}

Expand Down