zephyr: deprecate zephyr.h and use kernel.h header #6258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aiChaoSONG
requested review from
dbaluta,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
The zephyr header zephyr.h should be only used with CONFIG_LEGACY_INCLUDE_PATH, which is deprecate by both Zephyr and SOF. The latest zephyr main will complain if zephyr.h is used but CONFIG_LEGACY_INCLUDE_PATH disabled. This patch deprecates zephyr.h and uses kernel.h instead, so that we don't break with latest zephyr. Signed-off-by: Chao Song <chao.song@linux.intel.com>
paulstelian97
approved these changes
Sep 6, 2022
Collaborator
paulstelian97
left a comment
paulstelian97
left a comment
There was a problem hiding this comment.
Assuming basically the same things are included, this is a good change. So approved assuming build tests pass.
kv2019i
approved these changes
Sep 6, 2022
Collaborator
kv2019i
left a comment
kv2019i
left a comment
There was a problem hiding this comment.
Thanks @aiChaoSONG , looks good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The zephyr header zephyr.h should be only used with
CONFIG_LEGACY_INCLUDE_PATH, which is deprecate by both
Zephyr and SOF.
The latest zephyr main will complain if zephyr.h is
used but CONFIG_LEGACY_INCLUDE_PATH disabled.
This patch deprecates zephyr.h and uses kernel.h instead,
so that we don't break with latest zephyr.
Signed-off-by: Chao Song chao.song@linux.intel.com