-
Notifications
You must be signed in to change notification settings - Fork 349
topology2: Add kcps pipeline attribute #7160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Not sure if I should add some constraints etc., but AFAIK this should be enough get started, and to be able to test Linux driver side. |
|
Added { |
|
Finally the deepbuffer-pipeline has different kcps value than the rest of the pipelines. |
lgirdwood
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jsarha we also need the real deepbuffer number on MTL too with current code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both this value and the 400k value need to come from a platform file. e.g.
include(platform.conf)
kcps PLATFORM_DEEPBUFFER_KCPS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why @lgirdwood, if you have processing for the deep buffer pipeline, that can be entirely dependent on the module that's added on this pipeline. Different algorithms might have different requirements, there's no good default value that work for a given platform across all algorithms or configurations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should only be overridden in the machine topology file where it can be used to adjust machine specific pipelines (aligns with Windows use case now).
Adds kcps attribute to pipeline class with 0 default value. The default can be overrided with KCPS_PIPELINE_DEFAULT define. Signed-off-by: Jyri Sarha <jyri.sarha@intel.com>
Adds kcps attribute to pipeline class with 400000 default value, and overrides the value in deepbuffer-playback pipeline with 50000.