Skip to content

Conversation

@jsarha
Copy link
Contributor

@jsarha jsarha commented Feb 22, 2023

Adds kcps attribute to pipeline class with 400000 default value, and overrides the value in deepbuffer-playback pipeline with 50000.

@jsarha
Copy link
Contributor Author

jsarha commented Feb 22, 2023

Not sure if I should add some constraints etc., but AFAIK this should be enough get started, and to be able to test Linux driver side.

@lgirdwood
Copy link
Member

@yongzhi1 which pipelines do you expect to use LF clock, pls let @jsarha know so we can update this PR.

@jsarha
Copy link
Contributor Author

jsarha commented Feb 22, 2023

Added {
# Token reference and type
token_ref "sof_tkn_scheduler.word"
} to attribute definition. Without it nothing is added to the topology.

@jsarha
Copy link
Contributor Author

jsarha commented Feb 23, 2023

Finally the deepbuffer-pipeline has different kcps value than the rest of the pipelines.

Copy link
Member

@lgirdwood lgirdwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jsarha we also need the real deepbuffer number on MTL too with current code.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both this value and the 400k value need to come from a platform file. e.g.

include(platform.conf)
kcps PLATFORM_DEEPBUFFER_KCPS

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why @lgirdwood, if you have processing for the deep buffer pipeline, that can be entirely dependent on the module that's added on this pipeline. Different algorithms might have different requirements, there's no good default value that work for a given platform across all algorithms or configurations.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should only be overridden in the machine topology file where it can be used to adjust machine specific pipelines (aligns with Windows use case now).

Adds kcps attribute to pipeline class with 0 default value.

The default can be overrided with KCPS_PIPELINE_DEFAULT define.

Signed-off-by: Jyri Sarha <jyri.sarha@intel.com>
@jsarha jsarha marked this pull request as ready for review February 28, 2023 12:48
@jsarha jsarha requested a review from ranj063 as a code owner February 28, 2023 12:48
@lgirdwood lgirdwood merged commit 3ad30d5 into thesofproject:main Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants