platform: mtl: lowest clock as default #7233
Conversation
tmleman
requested review from
dbaluta,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
This patch sets lowest clock as default for Meteorlake platform. In current version FW can do unnecessary clocks switching operations. FW should start from low value and scale-up if necessary. Signed-off-by: Tomasz Leman <tomasz.m.leman@intel.com>
|
We can't merge this until the KCPS_REGISTER stuff is merged to kernel and topologies and we have sane values. @jsarha @ujfalusi are we ready? E.g. thesofproject/linux#4213 and friends. |
#7160 is merged, but it currently only has the 0 kcps defined as the default value for all pipelines. |
|
This PR does not need any KCPS stuff. Our default clock is the lowest one, thats why we have to force HP clock in init (in current code).
And we should keep it at 0. This is calculated by FW based on manifest data (currently only on MTL-004 branch). |
kv2019i
left a comment
kv2019i
left a comment
There was a problem hiding this comment.
@abonislawski wrote:
And we should keep it at 0. This is calculated by FW based on manifest data (currently only on MTL-004 branch).
Right, so it's 0 in tplg and fw doesn't calculate so this patch will break MTL in main as DSP clock will be kept at lowest level? -1 until this is clarified. Shouldn't the calculation basd on FW data (or higher default in tplg) be merged first, before we do this PR.
Driver should use kcps_register to adjust this if necessary.
Hmm, how will topology authors know when it is necessary? This seems very fuzzy to me and we need to have this documented somewhere else then review comments..
abonislawski
left a comment
abonislawski
left a comment
There was a problem hiding this comment.
yeap, actually we cant merge it now because temporary HP switch in init will not update clk info so its better to keep it as is for now
|
Assigning milestone so this can be tracked and merged once dependencies are all in place. |
|
Since it will not gonna be merge in the near future I'm closing this PR. |
7 participants
This patch sets lowest clock as default for Meteorlake platform. In current version FW can do unnecessary clocks switching operations. FW should start from low value and scale-up if necessary.