Skip to content

Conversation

@marc-hb
Copy link
Collaborator

@marc-hb marc-hb commented May 9, 2023

3 commits

marc-hb added 3 commits May 9, 2023 19:34
Update comments for brand new IPC4 support. No functional change.

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Fix the comment indentation to show it applies only to the older fuzzer.

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Hot on the heels of PR thesofproject#7531.

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
@marc-hb marc-hb changed the title .github: fuzz IPC4 too [SKIP SOF-TEST] .github: fuzz IPC4 too May 9, 2023
@marc-hb
Copy link
Collaborator Author

marc-hb commented May 9, 2023

@marc-hb marc-hb marked this pull request as ready for review May 9, 2023 19:46
@marc-hb marc-hb mentioned this pull request May 9, 2023
Copy link
Contributor

@cujomalainey cujomalainey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@iuliana-prodan
Copy link
Contributor

iuliana-prodan commented May 10, 2023

https://github.com/thesofproject/sof/actions/runs/4929778823/jobs/8809848778?pr=7579 is a known imx8m rename zephyrproject-rtos/zephyr#57084, unrelated.

@marc-hb can you please, help me a bit with this failure?

I see here that is using Zephyr's revision: HEAD is now at 3e02d48e4 ("driver: adc: infineon: Adding ADC driver"), which doesn't have the commits from zephyrproject-rtos/zephyr#57084, but it complaints on "fatal error: nxp/nxp_imx/mimx8ml8dvnlz-pinctrl.dtsi: No such file or directory" - this dtsi is added in this commit, part of the aforementioned PR.

Also, the hal_xtensa is: HEAD is now at 63f6553 ("soc: rename SoCs to be consistent and match zephyr/sof"), which, the same as zephyr, doesn't have the renaming for imx8m.

I've compiled SOF with zephyr for imx8m, both with xtensa-build-zephyr.py from SOF (here's the imx8m build log - I have the same zephyr revision and xtensa_hal as seen here) and from zephyr repo (on latest main - here's the imx8m build log - latest zephyr.txt).
Either way, I don't get any failures.

So, what's different here? Am I missing something?

Thank you!

@marc-hb
Copy link
Collaborator Author

marc-hb commented May 10, 2023

"zmain" checks like https://github.com/thesofproject/sof/actions/runs/4929778823/jobs/8809848778?pr=7579 ignore the manifest, they test for compatibility with the zephyr main branch. They should be warnings not errors but Github supports only two colors.

The "fix" is to not leave sof/west.yml trailing too far behind.

@marc-hb
Copy link
Collaborator Author

marc-hb commented May 10, 2023

https://sof-ci.01.org/sof-pr-viewer/#/build/PR7579/build11962909 failed with the network error below. This can be ignored, this pure Github Actions PR does not affect other tests in any way.

Lots of yellow on https://www.githubstatus.com/ right now.

13:40:39,247 INFO  - west update
13:40:39,427 INFO  - === updating zephyr (zephyr):
13:40:39,428 INFO  - --- zephyr: initializing
13:40:39,438 INFO  - Initialized empty Git repository in /buildagent/workspace/24733/zephyr/.git/
13:40:39,445 INFO  - --- zephyr: fetching, need revision 3e02d48e4ead9978d10ee760c640bf55873f6e95
14:04:35,056 INFO  - fatal: the remote end hung up unexpectedly
14:04:35,057 INFO  - fatal: early EOF
14:04:35,058 INFO  - fatal: index-pack failed
14:04:35,069 INFO  - FATAL ERROR: command exited with status 128: fetch -f --tags -- https://github.com/zephyrproject-rtos/zephyr 'refs/heads/*:refs/west/*'

@iuliana-prodan
Copy link
Contributor

"zmain" checks like https://github.com/thesofproject/sof/actions/runs/4929778823/jobs/8809848778?pr=7579 ignore the manifest, they test for compatibility with the zephyr main branch. They should be warnings not errors but Github supports only two colors.

The "fix" is to not leave sof/west.yml trailing too far behind.

I see in CI we are doing a "select zephyr revision", but I don't see a "west update" after this.
There might be some modifications, in zephyr, on west.yml that we are not taking into consideration.
So we are changing zephyr revision, but not the hals.

I believe we should have a west update after modifying the zephyr version.

@marc-hb
Copy link
Collaborator Author

marc-hb commented May 11, 2023

I believe we should have a west update after modifying the zephyr version.

Well spotted. However I did that in #7586 and on my workstation and it still fails the same.

This is off-topic here, let's discuss this imx8m issue in #7586

@kv2019i kv2019i merged commit 45c3f13 into thesofproject:main May 11, 2023
marc-hb added a commit to marc-hb/sof that referenced this pull request May 11, 2023
We import hal_xtensa indirectly through zephyr/west.yml.

When overriding the Zephyr revision in sof/west.yml to test the Zephyr
main branch "zmain", we must also update the version of hal_xtensa
specified in zephyr/west.yml. Stop doing a manual, single repo git fetch
and use a submanifest to perform this correctly. This is exactly why
submanifests/ were added in the first place.

These fixes the imx8m compilation error spotted and discussed
in (unrelated) thesofproject#7579 following the IMX rename in
zephyrproject-rtos/zephyr#57084 and
zephyrproject-rtos/zephyr#57795

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
ranj063 pushed a commit that referenced this pull request May 12, 2023
We import hal_xtensa indirectly through zephyr/west.yml.

When overriding the Zephyr revision in sof/west.yml to test the Zephyr
main branch "zmain", we must also update the version of hal_xtensa
specified in zephyr/west.yml. Stop doing a manual, single repo git fetch
and use a submanifest to perform this correctly. This is exactly why
submanifests/ were added in the first place.

These fixes the imx8m compilation error spotted and discussed
in (unrelated) #7579 following the IMX rename in
zephyrproject-rtos/zephyr#57084 and
zephyrproject-rtos/zephyr#57795

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
@marc-hb marc-hb deleted the IPC4fuzz branch May 17, 2023 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants