-
Notifications
You must be signed in to change notification settings - Fork 349
[SKIP SOF-TEST] .github/zephyr: align hal_xtensa when compiling with Zephyr main branch #7586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
697c59e to
91ed161
Compare
This comment was marked as resolved.
This comment was marked as resolved.
The Let me see how to fix this, I don't want to bring nxp_hal when compiling SOF with zephyr - for now it is not needed. I'll answer here to this comment, also. The was not fixed (only locally on my machine :) ) because it was only related with NXP i.MX8MP, since the XCC_TOOLS_VERSION is too long (xtensa-nxp_imx8m_adsp_zephyr...), more than 32 as defined here. |
|
@marc-hb I've fix it in zephyrproject-rtos/zephyr#57795 |
|
https://github.com/thesofproject/sof/actions/runs/4951673081/jobs/8856954534?pr=7586 is now passing \o/ One final touch and will mark "ready for review" today. |
We import hal_xtensa indirectly through zephyr/west.yml. When overriding the Zephyr revision in sof/west.yml to test the Zephyr main branch "zmain", we must also update the version of hal_xtensa specified in zephyr/west.yml. Stop doing a manual, single repo git fetch and use a submanifest to perform this correctly. This is exactly why submanifests/ were added in the first place. These fixes the imx8m compilation error spotted and discussed in (unrelated) thesofproject#7579 following the IMX rename in zephyrproject-rtos/zephyr#57084 and zephyrproject-rtos/zephyr#57795 Signed-off-by: Marc Herbert <marc.herbert@intel.com>
|
https://github.com/thesofproject/sof/actions/runs/4952716704/jobs/8859424902 fixed and looking good. |
|
PR testing skipped as this is pure .github/action change |
We import hal_xtensa indirectly through zephyr/west.yml.
When overriding the Zephyr revision in sof/west.yml to test the Zephyr main branch "zmain", we must also update the version of hal_xtensa specified in zephyr/west.yml. Stop doing a manual, single repo git fetch and use a submanifest to perform this correctly. This is exactly why submanifests/ were added in the first place.
These fixes the imx8m compilation error spotted and discussed in (unrelated) #7579 following the IMX rename