-
Notifications
You must be signed in to change notification settings - Fork 349
ipc3: helper: Do not silently accept unrecognized component type in IPC #7948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0c4c197 to
c543af9
Compare
lyakh
reviewed
Jul 14, 2023
Return an error code from comp_specific_builder() if the component type is not recognized, instead of just silently ignoring the error. Signed-off-by: Jyri Sarha <jyri.sarha@linux.intel.com>
lyakh
approved these changes
Jul 14, 2023
lgirdwood
approved these changes
Jul 14, 2023
dbaluta
approved these changes
Jul 14, 2023
Member
Collaborator
|
@jsarha we get some problems with this patch when testing mixer on IPC3. Looks like there is no case for mixer and it goes on default -EINVAL value. Please see We get this error: |
Collaborator
Collaborator
|
@lyakh I am looking at this. |
Collaborator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return an error code from comp_specific_builder() if the component type is not recognized, instead of just silently ignoring the error.