ipc3: helper: Fix mixer scenario #7963
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With mixer after commit 21ed10a ("ipc3: helper: Do not silently accept unrecognized component type in IPC") we get the following error dma-trace src/ipc/ipc3/helper.c:333 ERROR comp_new(): component type not recognized This happens because now we return an error from comp_specific_builder() with the default case. Fix this by adding a case for mixer. Fixes: 21ed10a ("ipc3: helper: Do not silently accept unrecognized component type in IPC") Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
dbaluta
requested review from
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
LaurentiuM1234
approved these changes
Jul 18, 2023
juimonen
approved these changes
Jul 18, 2023
kv2019i
approved these changes
Jul 18, 2023
ranj063
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With mixer after commit 21ed10a ("ipc3: helper: Do not silently accept unrecognized component type in IPC") we get the following error
dma-trace src/ipc/ipc3/helper.c:333 ERROR comp_new(): component type not recognized
This happens because now we return an error from comp_specific_builder() with the default case.
Fix this by adding a case for mixer.
Fixes: 21ed10a ("ipc3: helper: Do not silently accept unrecognized component type in IPC")