Audio: SRC: Avoid divide by zero when source frame bytes is not set #8064
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Workaround, not yet root cause fix for start of streaming. The divide by zero would happen in source_get_data_frames_available() right after this addition. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
Collaborator
|
SOFCI TEST |
dbaluta
approved these changes
Aug 21, 2023
lgirdwood
requested changes
Aug 21, 2023
| s2 = cd->src.stage2; | ||
|
|
||
| /* Workaround for a pipeline issue in beginning of processing */ | ||
| if (!source_get_frame_bytes(source)) |
Member
There was a problem hiding this comment.
@singalsu lets take the real fix, the WA is just hiding the issue.
Collaborator
Author
There was a problem hiding this comment.
Agree, it looks like SSP copier is clearing the source parameters in copy start.
Contributor
|
what's the issue link for this zero case? |
Collaborator
Author
|
Closing this #8084 fixes the root cause. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround, not yet root cause fix for start of streaming. The divide by zero would happen in source_get_data_frames_available() right after this addition.