Skip to content

Audio: SRC: Avoid divide by zero when source frame bytes is not set #8064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
singalsu wants to merge 1 commit into from
Closed

Audio: SRC: Avoid divide by zero when source frame bytes is not set #8064

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/audio/src/src.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -685,6 +685,10 @@ static int src_get_copy_limits(struct comp_data *cd,
s1 = cd->src.stage1;
s2 = cd->src.stage2;

/* Workaround for a pipeline issue in beginning of processing */
if (!source_get_frame_bytes(source))
Copy link
Member

@lgirdwood lgirdwood Aug 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@singalsu lets take the real fix, the WA is just hiding the issue.

Copy link
Collaborator Author

@singalsu singalsu Aug 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, it looks like SSP copier is clearing the source parameters in copy start.

return -EIO;

/* Calculate how many blocks can be processed with
* available source and free sink frames amount.
*/
Expand Down