Prevent page scrolling while menu is open. #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thanks for your PR 😌 I just added your feature but, not setting by default. Now you can able activate in the options. |
Author
|
That's perfect, thanks! I may be sending a few more PR's in the future if that's ok? This is almost exactly what I've been looking for. (I also love the name/theme. Great work!) |
Owner
|
Oh, great! Of course you can send more PR's. If you need you can open some issues to discuss something too. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if scrolling while the menu is open was intended, however I couldn't find an option to do so.
If there is a way without this change let me know.