Skip to content

Prevent page scrolling while menu is open. #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
theus merged 1 commit into from
Jul 4, 2018
Merged

Prevent page scrolling while menu is open. #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dist/MenuChef.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/MenuChef.js.map
View file
Open in desktop

Large diffs are not rendered by default.

5 changes: 5 additions & 0 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
{
"name": "menuchef",
"version": "1.2.1",
"description": "Create hamburgers' menu like a chef",
"description": "Create hamburgers’ menu like a chef",
"main": "dist/MenuChef.js",
"dependencies": {
"hamburgers": "^0.9.3"
"hamburgers": "^0.9.3",
"no-scroll": "^2.1.1"
},
"devDependencies": {
"babel-core": "^6.26.3",
Expand Down
3 changes: 3 additions & 0 deletions src/MenuChef.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import setIF from './helpers/setIF'
import masterCook from './helpers/masterCook'
import setPublicVar from './helpers/setPublicVar'
import forEach from './helpers/forEach'
import noScroll from 'no-scroll'

// Theme assets
import './templates/main.scss'
Expand Down Expand Up @@ -405,6 +406,7 @@ class MenuChef {
self._options.onOpen()
self.$openButton.classList.add('is-active')
self._isOpen = true
noScroll.on()
}
/**
* @module public_methods
Expand All @@ -420,6 +422,7 @@ class MenuChef {
self._options.onClose()
self.$openButton.classList.remove('is-active')
self._isOpen = false
noScroll.off()
}
/**
* @module public_methods
Expand Down