[angular-ngrx-scss] - Gists panel improvements#456
Conversation
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
| padding: 1rem; | ||
| border-bottom: 1px solid variables.$gray300; | ||
| @media (min-width: 768px) { | ||
| padding: 2rem 0; |
There was a problem hiding this comment.
padding: 2rem 0 2rem 2rem;
or at least:
padding: 2rem;
padding-right: 0;
| <ng-container *ngIf="userGists$ | async as gists"> | ||
| <ng-container *ngIf="gists.length > 0"> | ||
| <div class="list-container"> | ||
| <ng-container *ngIf="gists.length > 0; else noGists"> |
There was a problem hiding this comment.
gists?.length
gists can be undefined or null here
There was a problem hiding this comment.
i would propose ngIf="(gists?.length)" . it is shorter and unbreakable :)
| aside { | ||
| background: variables.$white; | ||
| padding: 2rem; | ||
| @media (max-width: 768px) { |
There was a problem hiding this comment.
put the breakpoints to variables.scss and reuse them
There was a problem hiding this comment.
Or at least to local variables if they are not needed all over the app.
| gist.fileName | ||
| }}</a> | ||
| <li> | ||
| <a class="link" [href]="gist.url" target="_blank">{{ |
There was a problem hiding this comment.
minor: move {{ gist.fileName }} to separate line for readability. + it also can conflict with linting rules
angular-ngrx-scss/src/app/home/user-gists/user-gists.component.html
Outdated
Show resolved
Hide resolved
| }}</a> | ||
| </ng-container> | ||
| </div> | ||
| <ng-container *ngIf="(gists?.length); else noGists"> |
There was a problem hiding this comment.
remove excess container. Place the condition right on ui
| <li *ngFor="let gist of gists"> | ||
| <a class="link" [href]="gist.url" target="_blank"> | ||
| {{ gist.fileName }}</a | ||
| > |
There was a problem hiding this comment.
format the braces (think about linter rules)
<a class="link" [href]="gist.url" target="_blank">
{{ gist.fileName }}
</a>
2 participants
Description
Closes #186