Skip to content

[angular-ngrx-scss] - Gists panel improvements #456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SDaian merged 7 commits into from
Jul 12, 2022
Merged

[angular-ngrx-scss] - Gists panel improvements #456

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a15169d
[angular-ngrx-scss] - Gists panel improvements
SDaian Jul 11, 2022
a7bf329
Fix comments
SDaian Jul 12, 2022
b65fa49
Fix typo on scss file
SDaian Jul 12, 2022
3185247
Format check
SDaian Jul 12, 2022
b431dee
Remove innecesary container
SDaian Jul 12, 2022
228a374
format check fix
SDaian Jul 12, 2022
1b77997
Fix format check
SDaian Jul 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion angular-ngrx-scss/src/app/home/home.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,19 @@

.main {
display: grid;
grid-template-columns: 24rem 1fr;
grid-template-columns: 1fr;
grid-row: 2 / 3;
grid-column: 1 / 3;
background: variables.$gray100;
@media (min-width: variables.$md) {
grid-template-columns: 24rem 1fr;
}
}

aside {
background: variables.$white;
padding: 2rem;
@media (max-width: variables.$md) {
order: 2;
}
}
11 changes: 8 additions & 3 deletions angular-ngrx-scss/src/app/home/top-repositories/top-repositories.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,10 @@
@use '../../shared/styles/variables';

.top-repositories-container {
padding: 3rem;
padding: 1.5rem;
@media (min-width: variables.$md) {
padding: 3rem;
}
h2 {
font-size: 18px;
line-height: 28px;
Expand All @@ -14,9 +17,11 @@
border-width: 1px;
}
.repo-section {
padding: 2rem 0;
padding-left: 2rem;
padding: 1rem;
border-bottom: 1px solid variables.$gray300;
@media (min-width: variables.$md) {
padding: 2rem 0 2rem 2rem;
}
}
.view-all-link {
padding: 1.25rem;
Expand Down
20 changes: 11 additions & 9 deletions angular-ngrx-scss/src/app/home/user-gists/user-gists.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,16 @@
<div class="container">
<h3>Gists</h3>
<ng-container *ngIf="userGists$ | async as gists">
<ng-container *ngIf="gists.length > 0">
<div class="list-container">
<ng-container *ngFor="let gist of gists">
<a class="link" [href]="gist.url" target="_blank">{{
gist.fileName
}}</a>
</ng-container>
</div>
</ng-container>
<ul *ngIf="gists?.length; else noGists">
<li *ngFor="let gist of gists">
<a class="link" [href]="gist.url" target="_blank">
{{ gist.fileName }}
</a>
</li>
</ul>
</ng-container>
</div>

<ng-template #noGists>
<p>User does not have any gists</p>
</ng-template>
4 changes: 4 additions & 0 deletions angular-ngrx-scss/src/app/home/user-gists/user-gists.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@
padding: 2rem 0;
border-top: 1px solid variables.$gray300;
border-bottom: 1px solid variables.$gray300;
ul {
list-style: none;
padding: 0;
}
h3 {
font-weight: 600;
}
Expand Down