Merged
Conversation
Contributor
Author
|
The failing build is a weird dependency issue and fixed in #297. |
tysongach
force-pushed
the
tg-background-colors
branch
from
f8a7d3e to
91dfde5
Compare
`$base-background-color` is only used for setting the background color of form inputs. That variable name doesn't make sense in that context; it makes it seem as though you can set this variable and change the background color of the viewport. This change swaps the name of `$base-background-color` to `$viewport-background-color` and sets it as a value on the `html` element. It also removes the `$secondary-background-color` variable, which is not used at all. Finally, a specific and private `$_form-background-color` variable is added to set the background color on form inputs.
tysongach
force-pushed
the
tg-background-colors
branch
from
91dfde5 to
8342adc
Compare
ghost
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
$base-background-coloris only used for setting the background colorof form inputs. That variable name doesn't make sense in that context;
it makes it seem as though you can set this variable and change the
background color of the viewport.
This change swaps the name of
$base-background-colorto$viewport-background-colorand sets it as a value on thehtmlelement. It also removes the
$secondary-background-colorvariable,which is not used at all.
Finally, a specific and private
$_form-background-colorvariable isadded to set the background color on form inputs.