Conversation
CircleCI was inferring that `npm install` needed to be ran for project dependencies. This isn't case, as the Node dependencies are only used for spinning up a local development instance, not for tests. Running `npm install` was causing a failing build due to some issues in the packages: https://circleci.com/gh/thoughtbot/bitters/161 This change manually overrides CircleCI's inference, by telling it to only install the needed Ruby dependencies for testing. Circle docs: https://circleci.com/docs/1.0/configuration/ Failed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CircleCI was inferring that
npm installneeded to be ran for projectdependencies. This isn't case, as the Node dependencies are only used
for spinning up a local development instance, not for tests.
Running
npm installwas causing a failing build due to some issuesin the packages: https://circleci.com/gh/thoughtbot/bitters/161
This change manually overrides CircleCI's inference, by telling it to
only install the needed Ruby dependencies for testing.
Circle docs: https://circleci.com/docs/1.0/configuration/
Failed