fix: smooth drawer animation and respect animation preferences#10658
fix: smooth drawer animation and respect animation preferences#10658jasi381 wants to merge 1 commit intothunderbird:mainfrom
Conversation
|
The detekt issue should be a simple fix: Basically just swapping the Besides that, would you be willing to make a screen recording of this issue? I seem to be having trouble reproducing the initial issue to test the fix. |
|
Thank you so much for this contribution. |
|
Thanks for the feedback! For the animation improvements, I adjusted the drawer animation to make it smoother by increasing the duration from 200ms to 300ms and applying FastOutSlowInEasing so the motion feels less abrupt. I'm currently addressing the Detekt parameter order issue mentioned by @dani-zilla and will push the fix shortly. Regarding the UX suggestion from @Alecaddd, I’m also working on updating the implementation so the app respects the OS-wide animation preference instead of relying on a separate app-level option. I've attached short screen recordings below showing the behaviour before and after the animation changes to help with reproducing the issue. Before fix (original behaviour): before.mp4After animation improvement: after.mp4 |
…underbird#10480) The sidebar animation when switching between the account list and folder list was too fast/jarring, and played even when the user disabled animations OS-wide (Developer Options > animation scale = 0). - Increase animation duration from 200ms to 300ms with FastOutSlowInEasing - Read OS-wide ANIMATOR_DURATION_SCALE to detect disabled animations - Use snap() (instant transition) when OS animations are disabled in all drawer animations: account selector slide, account switch, and expand icon rotation
9aceabb to
e2f1c73
Compare
|
Just glanced over the code and didn't test it, but this fix seems to make the drawer respect system settings, but the application setting ("Use gaudy") still exists with an independent default. This means that all non-drawer animations still do not respect the system-wide settings. I think the correct fix is to refactor the setting (not any views) to a triple-state where the default is to inherit the system-wide setting. I'm working on that fix right now. |
|
Missing report label. Set exactly one of: |
Summary
FastOutSlowInEasingfor a smoother feelisShowAnimationstoDrawerConfigso the drawer respects the user's "Show animations" settingsnap()(instant, no animation) instead of slide/fadeTest plan