Skip to content

Conversation

@marsishandsome
Copy link
Collaborator

Signed-off-by: marsishandsome marsishandsome@gmail.com

What problem does this PR solve?

We create a additional class
https://github.com/tikv/migration/blob/main/online-bulk-load/src/main/scala/org/tikv/bulkload/SerializableKey.scala, because Key does not implmemnt Serializable.

What is changed and how it works?

let class Key implmemnts Serializable, so that SerializableKey is no more needed.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to be included in the release note

Signed-off-by: marsishandsome <marsishandsome@gmail.com>
Copy link
Contributor

@Little-Wallace Little-Wallace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marsishandsome
Copy link
Collaborator Author

/run-all-tests

@marsishandsome marsishandsome merged commit 5268af6 into tikv:master Sep 13, 2021
Copy link
Collaborator

@birdstorm birdstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants