add log for init TiSession #327
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: marsishandsome <marsishandsome@gmail.com>
Collaborator
Author
|
/run-all-tests |
Signed-off-by: marsishandsome <marsishandsome@gmail.com>
Collaborator
Author
|
/run-all-tests |
zz-jason
reviewed
Nov 17, 2021
Comment on lines
+579
to
+583
| logger.info("init host mapping: start"); | ||
| this.hostMapping = | ||
| Optional.ofNullable(getConf().getHostMapping()) | ||
| .orElseGet(() -> new DefaultHostMapping(this.etcdClient, conf.getNetworkMappingName())); | ||
| logger.info("init host mapping: end"); |
Member
There was a problem hiding this comment.
it's better to aggregate these logs into one single log:
init host mapping: started in xxx, tasks 12ms(or 12s)
marsishandsome
added a commit
to marsishandsome/client-java
that referenced
this pull request
Dec 1, 2021
marsishandsome
added a commit
to marsishandsome/client-java
that referenced
this pull request
Dec 1, 2021
Signed-off-by: marsishandsome <marsishandsome@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: marsishandsome marsishandsome@gmail.com
What problem does this PR solve?
add log for init TiSession
What is changed and how it works?
Check List
Tests
Code changes
Side effects
Related changes