Skip to content

add log for init TiSession #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marsishandsome merged 2 commits into from
Nov 16, 2021
Merged

add log for init TiSession #327

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c42f0b
add log for init TiSession
marsishandsome Nov 16, 2021
aba892e
address code review
marsishandsome Nov 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/main/java/org/tikv/common/PDClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,7 +340,7 @@ private GetMembersResponse getMembers(URI uri) {
}
return resp;
} catch (Exception e) {
logger.error("failed to get member from pd server.", e);
logger.warn("failed to get member from pd server.", e);
}
return null;
}
Expand Down Expand Up @@ -560,6 +560,7 @@ protected PDStub getAsyncStub() {
}

private void initCluster() {
logger.info("init cluster: start");
GetMembersResponse resp = null;
List<URI> pdAddrs = new ArrayList<>(getConf().getPdAddrs());
// shuffle PD addresses so that clients call getMembers from different PD
Expand All @@ -575,14 +576,18 @@ private void initCluster() {
.setDaemon(true)
.build()))
.build();
logger.info("init host mapping: start");
this.hostMapping =
Optional.ofNullable(getConf().getHostMapping())
.orElseGet(() -> new DefaultHostMapping(this.etcdClient, conf.getNetworkMappingName()));
logger.info("init host mapping: end");
Comment on lines +579 to +583
Copy link
Member

@zz-jason zz-jason Nov 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's better to aggregate these logs into one single log:

init host mapping: started in xxx, tasks 12ms(or 12s)

// The first request may cost too much latency
long originTimeout = this.timeout;
this.timeout = 2000;
for (URI u : pdAddrs) {
logger.info("get members with pd " + u + ": start");
resp = getMembers(u);
logger.info("get members with pd " + u + ": end");
if (resp != null) {
break;
}
Expand All @@ -603,7 +608,9 @@ private void initCluster() {

String leaderUrlStr = resp.getLeader().getClientUrls(0);
leaderUrlStr = uriToAddr(addrToUri(leaderUrlStr));
logger.info("createLeaderClientWrapper with leader " + leaderUrlStr + ": start");
createLeaderClientWrapper(leaderUrlStr);
logger.info("createLeaderClientWrapper with leader " + leaderUrlStr + ": end");
service =
Executors.newSingleThreadScheduledExecutor(
new ThreadFactoryBuilder()
Expand All @@ -630,6 +637,7 @@ private void initCluster() {
.build());
tiflashReplicaService.scheduleAtFixedRate(
this::updateTiFlashReplicaStatus, 10, 10, TimeUnit.SECONDS);
logger.info("init cluster: finish");
}

static class PDClientWrapper {
Expand Down