Skip to content

update error log #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
marsishandsome merged 2 commits into from
Nov 18, 2021
Merged

update error log #331

marsishandsome merged 2 commits into from
Nov 18, 2021

Conversation

@marsishandsome
Copy link
Collaborator

@marsishandsome marsishandsome commented Nov 18, 2021

Signed-off-by: marsishandsome marsishandsome@gmail.com

What problem does this PR solve?

update error log

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to be included in the release note

@marsishandsome
update error log
bce708d 
Signed-off-by: marsishandsome <marsishandsome@gmail.com>
@marsishandsome
Copy link
Collaborator Author

marsishandsome commented Nov 18, 2021

/run-all-tests

1 similar comment
@marsishandsome
Copy link
Collaborator Author

marsishandsome commented Nov 18, 2021

/run-all-tests

zz-jason
zz-jason reviewed Nov 18, 2021
View reviewed changes
@marsishandsome
address code review
763cef9 
Signed-off-by: marsishandsome <marsishandsome@gmail.com>
@marsishandsome
Copy link
Collaborator Author

marsishandsome commented Nov 18, 2021

/run-all-tests

zz-jason
zz-jason approved these changes Nov 18, 2021
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

birdstorm
birdstorm approved these changes Nov 18, 2021
View reviewed changes
Copy link
Collaborator

@birdstorm birdstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marsishandsome marsishandsome merged commit b1e0c93 into tikv:release-3.1 Nov 18, 2021
@marsishandsome marsishandsome mentioned this pull request Dec 1, 2021
Merged
marsishandsome added a commit to marsishandsome/client-java that referenced this pull request Dec 1, 2021
@marsishandsome
update error log (tikv#331)
49e9c39
marsishandsome added a commit to marsishandsome/client-java that referenced this pull request Dec 1, 2021
@marsishandsome
update error log (tikv#331)
3ae83c0 
Signed-off-by: marsishandsome <marsishandsome@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@birdstorm birdstorm birdstorm approved these changes

@ti-srebot ti-srebot ti-srebot approved these changes

+1 more reviewer

@zz-jason zz-jason zz-jason approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

status/LGT2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@marsishandsome @zz-jason @birdstorm @ti-srebot