Skip to content

update error log #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marsishandsome merged 2 commits into from
Nov 18, 2021
Merged

update error log #331

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bce708d
update error log
marsishandsome Nov 18, 2021
763cef9
address code review
marsishandsome Nov 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/main/java/org/tikv/common/PDClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,7 +368,6 @@ private synchronized boolean createLeaderClientWrapper(String leaderUrlStr) {
new PDClientWrapper(leaderUrlStr, leaderUrlStr, clientChannel, System.nanoTime());
timeout = conf.getTimeout();
} catch (IllegalArgumentException e) {
logger.error("Error updating leader. " + leaderUrlStr, e);
return false;
}
logger.info(String.format("Switched to new leader: %s", pdClientWrapper));
Expand All @@ -388,7 +387,6 @@ synchronized boolean createFollowerClientWrapper(String followerUrlStr, String l
pdClientWrapper = new PDClientWrapper(leaderUrls, followerUrlStr, channel, System.nanoTime());
timeout = conf.getForwardTimeout();
} catch (IllegalArgumentException e) {
logger.error("Error updating follower. " + followerUrlStr, e);
return false;
}
logger.info(String.format("Switched to new leader by follower forward: %s", pdClientWrapper));
Expand Down Expand Up @@ -591,8 +589,11 @@ private void initCluster() {
if (resp != null) {
break;
}
logger.error("Could not get leader member with pd: " + u);
}
if (resp == null) {
logger.error("Could not get leader member with: " + pdAddrs);
}

this.timeout = originTimeout;
checkNotNull(resp, "Failed to init client for PD cluster.");
long clusterId = resp.getHeader().getClusterId();
Expand Down