-
Notifications
You must be signed in to change notification settings - Fork 118
[close #550] rawkv: fix seek leader/proxy store early abort (#551) #564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[close #550] rawkv: fix seek leader/proxy store early abort (#551) #564
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
/run-all-tests |
zz-jason
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
Codecov Report
@@ Coverage Diff @@
## release-3.1 #564 +/- ##
==============================================
Coverage ? 29.56%
Complexity ? 1147
==============================================
Files ? 263
Lines ? 16581
Branches ? 1897
==============================================
Hits ? 4903
Misses ? 11119
Partials ? 559 Continue to review full report at Codecov.
|
|
/merge |
|
/run-all-tests |
zz-jason
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
cherry-pick #551 to release-3.1
You can switch your code base to this Pull Request by using git-extras:
# In client-java repo: git pr https://github.com/tikv/client-java/pull/564After apply modifications, you can push your change to this PR via:
Signed-off-by: iosmanthus myosmanthustree@gmail.com
What problem does this PR solve?
Issue Number: close #550
Problem Description:
This pull request ignores exceptions while probing the leader/proxy store for a region's peer list including a unit test for mocking encountering some abnormal store while doing probing.
Check List for Tests
This PR has been tested by at least one of the following methods: