Skip to content

Conversation

@ti-srebot
Copy link
Collaborator

@ti-srebot ti-srebot commented Mar 23, 2022

cherry-pick #551 to release-3.1
You can switch your code base to this Pull Request by using git-extras:

# In client-java repo:
git pr https://github.com/tikv/client-java/pull/564

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/client-java.git pr/564:release-3.1-e89ca5f37bb4

Signed-off-by: iosmanthus myosmanthustree@gmail.com

What problem does this PR solve?

Issue Number: close #550

Problem Description:

This pull request ignores exceptions while probing the leader/proxy store for a region's peer list including a unit test for mocking encountering some abnormal store while doing probing.

Check List for Tests

This PR has been tested by at least one of the following methods:

  • Unit test
  • Integration test

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Collaborator Author

/run-all-tests

zz-jason
zz-jason previously approved these changes Mar 23, 2022
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
iosmanthus and others added 3 commits March 23, 2022 16:52
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
@codecov
Copy link

codecov bot commented Mar 28, 2022

Codecov Report

❗ No coverage uploaded for pull request base (release-3.1@cf14239). Click here to learn what that means.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             release-3.1     #564   +/-   ##
==============================================
  Coverage               ?   29.56%           
  Complexity             ?     1147           
==============================================
  Files                  ?      263           
  Lines                  ?    16581           
  Branches               ?     1897           
==============================================
  Hits                   ?     4903           
  Misses                 ?    11119           
  Partials               ?      559           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf14239...bb864ae. Read the comment docs.

@iosmanthus
Copy link
Member

/merge

@ti-srebot
Copy link
Collaborator Author

/run-all-tests

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason merged commit 47abaaf into tikv:release-3.1 Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants