[close #550] rawkv: fix seek leader/proxy store early abort #551
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
ti-srebot
previously approved these changes
Mar 3, 2022
Member
|
@iosmanthus does it affect release 3.1 and release 3.2? |
Member
Author
Yes. Cherry-pick is needed. |
Member
Author
|
/merge |
Collaborator
|
/run-all-tests |
1 similar comment
Member
Author
|
/run-all-tests |
Collaborator
|
/run-all-tests |
Collaborator
|
/run-all-tests |
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
iosmanthus
dismissed stale reviews from ti-srebot, zz-jason, and marsishandsome
via
bcc2d54
Codecov Report
@@ Coverage Diff @@
## master #551 +/- ##
============================================
+ Coverage 31.95% 32.12% +0.16%
- Complexity 1329 1335 +6
============================================
Files 279 279
Lines 17372 17385 +13
Branches 1980 1981 +1
============================================
+ Hits 5552 5585 +33
+ Misses 11215 11193 -22
- Partials 605 607 +2
Continue to review full report at Codecov.
|
ti-srebot
pushed a commit
to ti-srebot/client-java
that referenced
this pull request
Mar 23, 2022
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
Collaborator
|
cherry pick to release-3.1 in PR #564 |
ti-srebot
pushed a commit
to ti-srebot/client-java
that referenced
this pull request
Mar 23, 2022
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
Collaborator
|
cherry pick to release-3.2 in PR #565 |
zz-jason
pushed a commit
that referenced
this pull request
Mar 28, 2022
zz-jason
pushed a commit
that referenced
this pull request
Mar 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: iosmanthus myosmanthustree@gmail.com
What problem does this PR solve?
Issue Number: close #550
Problem Description:
This pull request ignores exceptions while probing the leader/proxy store for a region's peer list including a unit test for mocking encountering some abnormal store while doing probing.
Check List for Tests
This PR has been tested by at least one of the following methods: