Skip to content

Conversation

@ti-srebot
Copy link
Collaborator

@ti-srebot ti-srebot commented Mar 23, 2022

cherry-pick #551 to release-3.2
You can switch your code base to this Pull Request by using git-extras:

# In client-java repo:
git pr https://github.com/tikv/client-java/pull/565

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/client-java.git pr/565:release-3.2-e89ca5f37bb4

Signed-off-by: iosmanthus myosmanthustree@gmail.com

What problem does this PR solve?

Issue Number: close #550

Problem Description:

This pull request ignores exceptions while probing the leader/proxy store for a region's peer list including a unit test for mocking encountering some abnormal store while doing probing.

Check List for Tests

This PR has been tested by at least one of the following methods:

  • Unit test
  • Integration test

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Collaborator Author

/run-all-tests

@zz-jason zz-jason enabled auto-merge (squash) March 23, 2022 04:51
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
@codecov
Copy link

codecov bot commented Mar 28, 2022

Codecov Report

❗ No coverage uploaded for pull request base (release-3.2@7a4904e). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 0ef5d90 differs from pull request most recent head e95b932. Consider uploading reports for the commit e95b932 to get more accurate results

@@              Coverage Diff               @@
##             release-3.2     #565   +/-   ##
==============================================
  Coverage               ?   30.87%           
  Complexity             ?     1280           
==============================================
  Files                  ?      279           
  Lines                  ?    17385           
  Branches               ?     1981           
==============================================
  Hits                   ?     5368           
  Misses                 ?    11409           
  Partials               ?      608           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a4904e...e95b932. Read the comment docs.

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason disabled auto-merge March 28, 2022 11:27
@zz-jason zz-jason merged commit e3e4fe7 into tikv:release-3.2 Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants