Skip to content

[close #570] mockserver: fix unstable mock server cluster setup #571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zz-jason merged 2 commits into from
Mar 25, 2022
Merged

[close #570] mockserver: fix unstable mock server cluster setup #571

zz-jason merged 2 commits into from
Mar 25, 2022

Conversation

@iosmanthus
Copy link
Member

@iosmanthus iosmanthus commented Mar 24, 2022

Signed-off-by: iosmanthus myosmanthustree@gmail.com

What problem does this PR solve?

Issue Number: close #570

What is changed and how does it work?

Allocate ports randomly for each mock server.

Check List for Tests

This PR has been tested by at least one of the following methods:

  • Unit test

Related changes

  • Need to cherry-pick to the release branch

@iosmanthus
mockserver: fix unstable mock server cluster setup
92c0e98 
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
@codecov
Copy link

codecov bot commented Mar 24, 2022 •
edited
Loading

Codecov Report

Merging #571 (e0604f4) into master (7278d5a) will increase coverage by 0.18%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #571      +/-   ##
============================================
+ Coverage     32.72%   32.91%   +0.18%     
- Complexity     1317     1330      +13     
============================================
  Files           270      270              
  Lines         17054    17054              
  Branches       1950     1950              
============================================
+ Hits           5581     5613      +32     
+ Misses        10869    10841      -28     
+ Partials        604      600       -4
Impacted Files Coverage Δ
src/main/java/io/grpc/stub/ClientCalls.java 48.51% <0.00%> (+0.33%) ⬆️
src/main/java/org/tikv/common/TiSession.java 71.15% <0.00%> (+0.48%) ⬆️
src/main/java/org/tikv/common/PDClient.java 59.75% <0.00%> (+0.48%) ⬆️
src/main/java/io/grpc/internal/ClientCallImpl.java 57.07% <0.00%> (+0.73%) ⬆️
...rc/main/java/io/grpc/netty/NettyClientHandler.java 56.89% <0.00%> (+0.86%) ⬆️
...ty/handler/codec/http2/Http2ConnectionHandler.java 48.16% <0.00%> (+1.22%) ⬆️
.../tikv/common/region/AbstractRegionStoreClient.java 75.46% <0.00%> (+2.77%) ⬆️
src/main/java/org/tikv/common/region/TiStore.java 61.53% <0.00%> (+5.12%) ⬆️
...va/org/tikv/common/region/StoreHealthyChecker.java 73.68% <0.00%> (+9.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7278d5a...e0604f4. Read the comment docs.

zz-jason
zz-jason approved these changes Mar 24, 2022
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason
Copy link
Member

zz-jason commented Mar 24, 2022

does it need to be cherry-picked to any release branches to make test stable?

@iosmanthus
Copy link
Member Author

iosmanthus commented Mar 24, 2022

does it need to be cherry-picked to any release branches to make the test stable?

Yes, tags added.

marsishandsome
marsishandsome approved these changes Mar 25, 2022
View reviewed changes
Copy link
Collaborator

@marsishandsome marsishandsome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iosmanthus
Copy link
Member Author

iosmanthus commented Mar 25, 2022

/merge

@zz-jason zz-jason merged commit f4e7c30 into tikv:master Mar 25, 2022
ti-srebot pushed a commit to ti-srebot/client-java that referenced this pull request Mar 25, 2022
@iosmanthus @ti-srebot
cherry pick tikv#571 to release-3.1
c8d856d 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Mar 25, 2022
Merged
@ti-srebot
Copy link
Collaborator

ti-srebot commented Mar 25, 2022

cherry pick to release-3.1 in PR #576

ti-srebot pushed a commit to ti-srebot/client-java that referenced this pull request Mar 25, 2022
@iosmanthus @ti-srebot
cherry pick tikv#571 to release-3.2
899703d 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Mar 25, 2022
Merged
@ti-srebot
Copy link
Collaborator

ti-srebot commented Mar 25, 2022

cherry pick to release-3.2 in PR #577

zz-jason pushed a commit that referenced this pull request Mar 29, 2022
@ti-srebot @iosmanthus
[close #570] mockserver: fix unstable mock server cluster setup (#571) (
c2b23db 
#576)

Co-authored-by: iosmanthus <dengliming@pingcap.com>
Co-authored-by: iosmanthus <myosmanthustree@gmail.com>
zz-jason pushed a commit that referenced this pull request Mar 29, 2022
@ti-srebot @iosmanthus
[close #570] mockserver: fix unstable mock server cluster setup (#571) (
ab591d8 
#577)

Co-authored-by: iosmanthus <dengliming@pingcap.com>
Co-authored-by: iosmanthus <myosmanthustree@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marsishandsome marsishandsome marsishandsome approved these changes

@ti-srebot ti-srebot ti-srebot approved these changes

+1 more reviewer

@zz-jason zz-jason zz-jason approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

status/LGT2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

mockserver: unstable mock server cluster setup

4 participants

@iosmanthus @zz-jason @ti-srebot @marsishandsome