Skip to content

Conversation

@ti-srebot
Copy link
Collaborator

@ti-srebot ti-srebot commented Mar 25, 2022

cherry-pick #571 to release-3.2
You can switch your code base to this Pull Request by using git-extras:

# In client-java repo:
git pr https://github.com/tikv/client-java/pull/577

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/client-java.git pr/577:release-3.2-f4e7c302adb9

Signed-off-by: iosmanthus myosmanthustree@gmail.com

What problem does this PR solve?

Issue Number: close #570

What is changed and how does it work?

Allocate ports randomly for each mock server.

Check List for Tests

This PR has been tested by at least one of the following methods:

  • Unit test

Related changes

  • Need to cherry-pick to the release branch

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Collaborator Author

/run-all-tests

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iosmanthus please resolve the conflicts

Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
…e-3.2-f4e7c302adb9

Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
@codecov
Copy link

codecov bot commented Mar 28, 2022

Codecov Report

❗ No coverage uploaded for pull request base (release-3.2@d4ecb2c). Click here to learn what that means.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             release-3.2     #577   +/-   ##
==============================================
  Coverage               ?   32.32%           
  Complexity             ?     1339           
==============================================
  Files                  ?      279           
  Lines                  ?    17462           
  Branches               ?     1981           
==============================================
  Hits                   ?     5645           
  Misses                 ?    11203           
  Partials               ?      614           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4ecb2c...92b36cc. Read the comment docs.

@iosmanthus
Copy link
Member

/merge

@ti-srebot
Copy link
Collaborator Author

@iosmanthus Oops! This PR requires at least 1 LGTMs to merge. The current number of LGTM is 0

@zz-jason zz-jason enabled auto-merge (squash) March 29, 2022 02:39
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason merged commit ab591d8 into tikv:release-3.2 Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants