[close #654] Add RegionCacheInvalidCallBack #653
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qidi1
force-pushed
the
cacheInvalidate
branch
from
a78d6f3 to
9783ed6
Compare
Codecov ReportBase: 37.65% // Head: 37.97% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #653 +/- ##
============================================
+ Coverage 37.65% 37.97% +0.32%
- Complexity 1589 1603 +14
============================================
Files 278 278
Lines 17420 17462 +42
Branches 1982 1984 +2
============================================
+ Hits 6559 6631 +72
+ Misses 10207 10175 -32
- Partials 654 656 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Member
|
Please open an issue to describe it. |
…hen the region cache fails, Add RegionCacheInvalidCallBack. Signed-off-by: qidi1 <1083369179@qq.com>
qidi1
force-pushed
the
cacheInvalidate
branch
from
9783ed6 to
56d1518
Compare
iosmanthus
changed the title
xuanyu66
suggested changes
Sep 26, 2022
src/main/java/org/tikv/common/operation/RegionErrorHandler.java
Outdated
Show resolved
Hide resolved
xuanyu66
reviewed
Sep 26, 2022
src/main/java/org/tikv/common/operation/RegionErrorHandler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: qidi1 <1083369179@qq.com>
Signed-off-by: qidi1 <1083369179@qq.com>
shiyuhang0
reviewed
Sep 27, 2022
src/main/java/org/tikv/common/operation/RegionErrorHandler.java
Outdated
Show resolved
Hide resolved
Daemonxiao
reviewed
Sep 27, 2022
xuanyu66
suggested changes
Sep 27, 2022
src/main/java/org/tikv/common/operation/RegionErrorHandler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: qidi1 <1083369179@qq.com>
Signed-off-by: qidi1 <1083369179@qq.com>
Signed-off-by: qidi1 <1083369179@qq.com>
xuanyu66
suggested changes
Sep 28, 2022
src/main/java/org/tikv/common/operation/RegionErrorHandler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: qidi1 <1083369179@qq.com>
Signed-off-by: qidi1 <1083369179@qq.com>
Signed-off-by: qidi1 <1083369179@qq.com>
Signed-off-by: qidi1 <1083369179@qq.com>
Signed-off-by: qidi1 <1083369179@qq.com>
xuanyu66
reviewed
Sep 29, 2022
src/main/java/org/tikv/common/operation/RegionErrorHandler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: qidi1 <1083369179@qq.com>
shiyuhang0
previously approved these changes
Sep 29, 2022
Collaborator
|
@shiyuhang0, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. You are not a reviewer or committer or co-leader or leader. |
|
This PR is stale because it has been open 30 days with no activity. Remove the status/stale label or comment or this PR will be closed in 7 days. |
|
This PR was closed because it has been stalled for 7 days with no activity. |
ti-srebot
pushed a commit
to ti-srebot/client-java
that referenced
this pull request
Jan 30, 2023
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
Collaborator
|
cherry pick to release-3.3 in PR #715 |
zhangyangyu
pushed a commit
that referenced
this pull request
Feb 9, 2023
Signed-off-by: ti-srebot <ti-srebot@pingcap.com> Co-authored-by: tomato <38561029+qidi1@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: qidi1 1083369179@qq.com
What problem does this PR solve?
Issue Number: close #654
Problem Description: TBD
What is changed and how does it work?
Add RegionCacheInvalidCallBack. Let the upper layers customize their own behavior when the region cache fails.
Code changes
Check List for Tests
This PR has been tested by at least one of the following methods:
Side effects
Related changes