-
Notifications
You must be signed in to change notification settings - Fork 118
[close #654] Add RegionCacheInvalidCallBack #653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
56d1518
Close #654 To let the upper layers customize their own behavior when …
qidi1 e94cb00
change callback to list
qidi1 ece0b10
format code
qidi1 454f689
change as comment
qidi1 5ef3118
change to synchronized
qidi1 a49125c
change list to copy on write
qidi1 922de9b
change to muti thread
qidi1 a8fe9c3
format code
qidi1 1fd41b6
add comment
qidi1 be66047
change to magical num
qidi1 b2db42e
add comment
qidi1 a0e00fc
change log levle
qidi1 46071f0
Merge branch 'master' into cacheInvalidate
shiyuhang0 21354fa
Fmt
shiyuhang0 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
130 changes: 130 additions & 0 deletions
130
src/test/java/org/tikv/common/CacheInvalidCallBackTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,130 @@ | ||
| /* | ||
| * Copyright 2022 TiKV Project Authors. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| * | ||
| */ | ||
|
|
||
| package org.tikv.common; | ||
|
|
||
| import static org.junit.Assert.assertEquals; | ||
| import static org.junit.Assert.fail; | ||
|
|
||
| import com.google.protobuf.ByteString; | ||
| import java.util.ArrayList; | ||
| import java.util.List; | ||
| import java.util.Optional; | ||
| import java.util.function.Function; | ||
| import org.junit.Test; | ||
| import org.tikv.common.event.CacheInvalidateEvent; | ||
| import org.tikv.common.region.RegionManager; | ||
| import org.tikv.common.region.RegionStoreClient; | ||
| import org.tikv.common.region.RegionStoreClient.RegionStoreClientBuilder; | ||
| import org.tikv.common.region.TiStore; | ||
| import org.tikv.common.util.BackOffer; | ||
| import org.tikv.common.util.ConcreteBackOffer; | ||
| import org.tikv.kvproto.Errorpb; | ||
| import org.tikv.kvproto.Errorpb.EpochNotMatch; | ||
| import org.tikv.kvproto.Errorpb.NotLeader; | ||
| import org.tikv.kvproto.Errorpb.StoreNotMatch; | ||
| import org.tikv.kvproto.Metapb; | ||
|
|
||
| public class CacheInvalidCallBackTest extends MockServerTest { | ||
|
|
||
| private RegionStoreClient createClient( | ||
| String version, Function<CacheInvalidateEvent, Void> cacheInvalidateCallBack) { | ||
| Metapb.Store meta = | ||
| Metapb.Store.newBuilder() | ||
| .setAddress(LOCAL_ADDR + ":" + port) | ||
| .setId(1) | ||
| .setState(Metapb.StoreState.Up) | ||
| .setVersion(version) | ||
| .build(); | ||
| TiStore store = new TiStore(meta); | ||
|
|
||
| RegionManager manager = new RegionManager(session.getConf(), session.getPDClient()); | ||
| manager.addCacheInvalidateCallback(cacheInvalidateCallBack); | ||
| RegionStoreClientBuilder builder = | ||
| new RegionStoreClientBuilder( | ||
| session.getConf(), session.getChannelFactory(), manager, session.getPDClient()); | ||
|
|
||
| return builder.build(region, store); | ||
| } | ||
|
|
||
| @Test | ||
| public void testcacheInvalidCallBack() { | ||
| String version = "3.0.12"; | ||
| CacheInvalidateCallBack cacheInvalidateCallBack = new CacheInvalidateCallBack(); | ||
| doRawGetTest(createClient(version, cacheInvalidateCallBack), cacheInvalidateCallBack); | ||
| } | ||
|
|
||
| public void doRawGetTest( | ||
| RegionStoreClient client, CacheInvalidateCallBack cacheInvalidateCallBack) { | ||
| server.put("key1", "value1"); | ||
| Optional<ByteString> value = client.rawGet(defaultBackOff(), ByteString.copyFromUtf8("key1")); | ||
| assertEquals(ByteString.copyFromUtf8("value1"), value.get()); | ||
| try { | ||
| server.putError( | ||
| "error1", () -> Errorpb.Error.newBuilder().setNotLeader(NotLeader.getDefaultInstance())); | ||
| client.rawGet(defaultBackOff(), ByteString.copyFromUtf8("error1")); | ||
| fail(); | ||
| } catch (Exception e) { | ||
| assertEquals(1, cacheInvalidateCallBack.cacheInvalidateEvents.size()); | ||
| } | ||
| server.putError( | ||
| "failure", | ||
| () -> Errorpb.Error.newBuilder().setEpochNotMatch(EpochNotMatch.getDefaultInstance())); | ||
| try { | ||
| client.rawGet(defaultBackOff(), ByteString.copyFromUtf8("failure")); | ||
| fail(); | ||
| } catch (Exception e) { | ||
| sleep(1000); | ||
| assertEquals(2, cacheInvalidateCallBack.cacheInvalidateEvents.size()); | ||
| } | ||
| server.putError( | ||
| "store_not_match", | ||
| () -> Errorpb.Error.newBuilder().setStoreNotMatch(StoreNotMatch.getDefaultInstance())); | ||
| try { | ||
| client.rawGet(defaultBackOff(), ByteString.copyFromUtf8("failure")); | ||
| fail(); | ||
| } catch (Exception e) { | ||
| sleep(1000); | ||
| assertEquals(3, cacheInvalidateCallBack.cacheInvalidateEvents.size()); | ||
| } | ||
| server.clearAllMap(); | ||
| client.close(); | ||
| } | ||
|
|
||
| private void sleep(int time) { | ||
| try { | ||
| Thread.sleep(time); | ||
| } catch (InterruptedException e) { | ||
| fail(); | ||
| } | ||
| } | ||
|
|
||
| private BackOffer defaultBackOff() { | ||
| return ConcreteBackOffer.newCustomBackOff(1000); | ||
| } | ||
|
|
||
| static class CacheInvalidateCallBack implements Function<CacheInvalidateEvent, Void> { | ||
|
|
||
| public List<CacheInvalidateEvent> cacheInvalidateEvents = new ArrayList<>(); | ||
|
|
||
| @Override | ||
| public Void apply(CacheInvalidateEvent cacheInvalidateEvent) { | ||
| cacheInvalidateEvents.add(cacheInvalidateEvent); | ||
| return null; | ||
| } | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.