Skip to content

Conversation

@shiyuhang0
Copy link
Collaborator

@shiyuhang0 shiyuhang0 commented Apr 27, 2023

What problem does this PR solve?

FIx CI fail.

What is changed and how does it work?

CI depends on the output of TiUP playground to get PD address which is fragile. playground v1.12.1 will not output pd address causing the tests to fail.

So, this pr specify pd port.

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has methods of interface change
  • Has persistent data change
  • No code

Check List for Tests

This PR has been tested by at least one of the following methods:

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Possible performance regression, WHY: TBD
  • Increased code complexity, WHY: TBD
  • Breaking backward compatibility, WHY: TBD
  • NO side effects

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to be included in the release note
  • NO related changes

@codecov
Copy link

codecov bot commented Apr 27, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.98 ⚠️

Comparison is base (a523312) 38.11% compared to head (465b8b2) 37.14%.

❗ Current head 465b8b2 differs from pull request most recent head 9f5c45a. Consider uploading reports for the commit 9f5c45a to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #741      +/-   ##
============================================
- Coverage     38.11%   37.14%   -0.98%     
+ Complexity     1613     1570      -43     
============================================
  Files           278      278              
  Lines         17482    17482              
  Branches       1986     1986              
============================================
- Hits           6663     6493     -170     
- Misses        10154    10329     +175     
+ Partials        665      660       -5     

see 17 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@shiyuhang0 shiyuhang0 changed the title ci test fix CI Apr 27, 2023
Signed-off-by: shiyuhang <1136742008@qq.com>
Signed-off-by: shiyuhang <1136742008@qq.com>
Signed-off-by: shiyuhang <1136742008@qq.com>
Signed-off-by: shiyuhang <1136742008@qq.com>
Signed-off-by: shiyuhang <1136742008@qq.com>
Signed-off-by: shiyuhang <1136742008@qq.com>
Signed-off-by: shiyuhang <1136742008@qq.com>
Signed-off-by: shiyuhang <1136742008@qq.com>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: cannot checkout 3.2: error checking out 3.2: exit status 1. output: error: pathspec '3.2' did not match any file(s) known to git

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: cannot checkout 3.1: error checking out 3.1: exit status 1. output: error: pathspec '3.1' did not match any file(s) known to git

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: cannot checkout 3.3: error checking out 3.3: exit status 1. output: error: pathspec '3.3' did not match any file(s) known to git

@shiyuhang0
Copy link
Collaborator Author

/cherry-pick release-3.3

@shiyuhang0
Copy link
Collaborator Author

/cherry-pick release-3.2

@shiyuhang0
Copy link
Collaborator Author

/cherry-pick release-3.1

@ti-chi-bot ti-chi-bot mentioned this pull request Apr 27, 2023
@ti-chi-bot
Copy link
Member

@shiyuhang0: new pull request created to branch release-3.3: #743.

Details

In response to this:

/cherry-pick release-3.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot mentioned this pull request Apr 27, 2023
@ti-chi-bot
Copy link
Member

@shiyuhang0: new pull request created to branch release-3.2: #744.

Details

In response to this:

/cherry-pick release-3.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot mentioned this pull request Apr 27, 2023
@ti-chi-bot
Copy link
Member

@shiyuhang0: new pull request created to branch release-3.1: #745.

Details

In response to this:

/cherry-pick release-3.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

zhangyangyu pushed a commit that referenced this pull request Apr 27, 2023
Signed-off-by: shiyuhang <1136742008@qq.com>
shiyuhang0 pushed a commit that referenced this pull request May 24, 2023
shiyuhang0 pushed a commit that referenced this pull request May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants