Skip to content

Conversation

@ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #741

What problem does this PR solve?

FIx CI fail.

What is changed and how does it work?

CI depends on the output of TiUP playground to get PD address which is fragile. playground v1.12.1 will not output pd address causing the tests to fail.

So, this pr specify pd port.

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has methods of interface change
  • Has persistent data change
  • No code

Check List for Tests

This PR has been tested by at least one of the following methods:

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Possible performance regression, WHY: TBD
  • Increased code complexity, WHY: TBD
  • Breaking backward compatibility, WHY: TBD
  • NO side effects

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to be included in the release note
  • NO related changes

Signed-off-by: shiyuhang <1136742008@qq.com>
Signed-off-by: shiyuhang <1136742008@qq.com>
Signed-off-by: shiyuhang <1136742008@qq.com>
Signed-off-by: shiyuhang <1136742008@qq.com>
Signed-off-by: shiyuhang <1136742008@qq.com>
Signed-off-by: shiyuhang <1136742008@qq.com>
Signed-off-by: shiyuhang <1136742008@qq.com>
Signed-off-by: shiyuhang <1136742008@qq.com>
@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-3.2@790d347). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@              Coverage Diff               @@
##             release-3.2     #744   +/-   ##
==============================================
  Coverage               ?   32.33%           
  Complexity             ?     1345           
==============================================
  Files                  ?      279           
  Lines                  ?    17462           
  Branches               ?     1981           
==============================================
  Hits                   ?     5646           
  Misses                 ?    11216           
  Partials               ?      600           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@shiyuhang0 shiyuhang0 merged commit 8870606 into tikv:release-3.2 May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants