Conversation
siddontang
reviewed
Oct 23, 2018
siddontang
reviewed
Oct 23, 2018
Contributor
|
Now we have already supported end_key for the scan request, see pingcap/kvproto#306, we need to change our API. |
Member
Author
Cool, I happened to change the KeyRange into RangeBounds per @Hoverbear's suggestion. So the API can naturally support closed interval now. |
Hoverbear
reviewed
Nov 14, 2018
Hoverbear
reviewed
Nov 14, 2018
Hoverbear
reviewed
Nov 14, 2018
sunxiaoguang
force-pushed
the
public_api_rfc
branch
2 times, most recently
from
b0c0261 to
fbac7c4
Compare
Hoverbear
approved these changes
Nov 19, 2018
Contributor
Hoverbear
left a comment
Hoverbear
left a comment
There was a problem hiding this comment.
LGTM. We're merging this with the agreement that we will reflect additional feedback in tikv/rfcs#7 in a later PR. :)
Signed-off-by: Xiaoguang Sun <sunxiaoguang@zhihu.com>
Signed-off-by: Xiaoguang Sun <sunxiaoguang@zhihu.com>
Signed-off-by: Xiaoguang Sun <sunxiaoguang@zhihu.com>
Signed-off-by: Xiaoguang Sun <sunxiaoguang@zhihu.com>
Signed-off-by: Xiaoguang Sun <sunxiaoguang@zhihu.com>
Signed-off-by: Xiaoguang Sun <sunxiaoguang@zhihu.com>
Signed-off-by: Xiaoguang Sun <sunxiaoguang@zhihu.com>
Signed-off-by: Xiaoguang Sun <sunxiaoguang@zhihu.com>
Signed-off-by: Xiaoguang Sun <sunxiaoguang@zhihu.com>
Signed-off-by: Xiaoguang Sun <sunxiaoguang@zhihu.com>
Signed-off-by: Xiaoguang Sun <sunxiaoguang@zhihu.com>
Signed-off-by: Xiaoguang Sun <sunxiaoguang@zhihu.com>
Signed-off-by: Xiaoguang Sun <sunxiaoguang@zhihu.com>
Signed-off-by: Xiaoguang Sun <sunxiaoguang@zhihu.com>
Signed-off-by: Xiaoguang Sun <sunxiaoguang@zhihu.com>
Signed-off-by: Xiaoguang Sun <sunxiaoguang@zhihu.com>
Signed-off-by: Xiaoguang Sun <sunxiaoguang@zhihu.com>
sunxiaoguang
force-pushed
the
public_api_rfc
branch
from
8948eab to
f02d339
Compare
Hoverbear
approved these changes
Nov 19, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TiKV public API design RFC