TiKV Rust Client RFC by sunxiaoguang · Pull Request #7 · tikv/rfcs

sunxiaoguang · 2018-10-25T09:56:43Z

Introduces the API design for a Rust client for TiKV.

Signed-off-by: Xiaoguang Sun <sunxiaoguang@zhihu.com>

siddontang · 2018-10-30T00:47:40Z

PTAL @tikv/pingcap-i18n

Signed-off-by: Xiaoguang Sun <sunxiaoguang@zhihu.com>

Hoverbear · 2018-10-31T17:33:44Z

Great job @sunxiaoguang, thanks for tackling this huge task! My hero. 😂

Signed-off-by: Xiaoguang Sun <sunxiaoguang@zhihu.com>

Hoverbear · 2018-12-20T23:09:45Z

Hi friends! Are there any remaining points anyone would like to see addressed in this PR? We will likely amend this RFC in the future to reflect the final function signatures etc in the implemented code. That will be a different PR.

Hoverbear · 2019-01-15T00:35:34Z

Now that we've seen tikv/client-rust#14 merged we can revisit & update this document.

Signed-off-by: Ana Hobden <operator@hoverbear.org>

* add schedule limit design Signed-off-by: disksing <i@disksing.com> * Update text/2018-09-17-schedule-limit.md Signed-off-by: disksing <i@disksing.com> Co-Authored-By: disksing <i@disksing.com> * Update text/2018-09-17-schedule-limit.md Signed-off-by: disksing <i@disksing.com> Co-Authored-By: disksing <i@disksing.com> * Update text/2018-09-17-schedule-limit.md Signed-off-by: disksing <i@disksing.com> Co-Authored-By: disksing <i@disksing.com> * Update text/2018-09-17-schedule-limit.md Signed-off-by: disksing <i@disksing.com> Co-Authored-By: disksing <i@disksing.com> * Update text/2018-09-17-schedule-limit.md Signed-off-by: disksing <i@disksing.com> Co-Authored-By: disksing <i@disksing.com> * Update text/2018-09-17-schedule-limit.md Signed-off-by: disksing <i@disksing.com> Co-Authored-By: disksing <i@disksing.com> * Update text/2018-09-17-schedule-limit.md Signed-off-by: disksing <i@disksing.com> Co-Authored-By: disksing <i@disksing.com> * Update text/2018-09-17-schedule-limit.md Signed-off-by: disksing <i@disksing.com> Co-Authored-By: disksing <i@disksing.com> * Update text/2018-09-17-schedule-limit.md Signed-off-by: disksing <i@disksing.com> Co-Authored-By: disksing <i@disksing.com> * Update text/2018-09-17-schedule-limit.md Signed-off-by: disksing <i@disksing.com> Co-Authored-By: disksing <i@disksing.com> * Update text/2018-09-17-schedule-limit.md Signed-off-by: disksing <i@disksing.com> Co-Authored-By: disksing <i@disksing.com> * Update 2018-09-17-schedule-limit.md Signed-off-by: disksing <i@disksing.com> * Fix lints Signed-off-by: Hoverbear <operator@hoverbear.org> * Update text/2018-09-17-schedule-limit.md Signed-off-by: A. Hobden <operator@hoverbear.org> Co-Authored-By: disksing <i@disksing.com> * Update text/2018-09-17-schedule-limit.md Signed-off-by: A. Hobden <operator@hoverbear.org> Co-Authored-By: disksing <i@disksing.com> * use Region instead of region Signed-off-by: disksing <i@disksing.com> * Update text/2018-09-17-schedule-limit.md Signed-off-by: Caitin <34535727+caitinchen@users.noreply.github.com> Co-Authored-By: disksing <i@disksing.com> Signed-off-by: Ana Hobden <operator@hoverbear.org>

Hoverbear · 2019-02-21T19:53:36Z

Trying to resolve the DCO problem on this PR. :)

* unified log format Signed-off-by: Wenxuan Shi <hi@breeswish.org> Signed-off-by: Ana Hobden <operator@hoverbear.org>

* introduce PD simulator Signed-off-by: Ryan Leung <rleungx@gmail.com> Signed-off-by: Ana Hobden <operator@hoverbear.org>

Signed-off-by: Ana Hobden <operator@hoverbear.org>

…tikv-client-rust

My name is Sun Xiaoguang from Zhihu, where I help make a BigTable like system focusd on OLTP that is using TiKV. I've been contributing to TiKV and the library ecosystem for around a year now. I first touched the TiKV codebase since around March 2018. As part of my involvement with the project I've contributed several improvements to the TiKV Project: * [Added raw batch put/get/delete/scan](pingcap/kvproto#244) * [Changed `get_region` and `get_region_info` to use a common implementation](#3521) * [Print help message when starting tikv-ctl without argument](#3531) * [Clean up unused #[allow] directives](#3553) I also am the first and primary author of the [TiKV Rust Client](https://github.com/tikv/client-rust). You can see related PRs for that here: * [TiKV Rust Client RFC](tikv/rfcs#7) * [The initial version of Raw KV Implementation](tikv/client-rust#14) * [Change `raw::Client::get` to return `Option<Value>`](tikv/client-rust#24) * [Remove cf and batch_scan from `example/raw.rs`](tikv/client-rust#21) I also made the first PR to the mock TiKV project: [A basic implementation of mock TiKV API surface](tikv/mock-tikv#1) As part of my involvement, the TiKV team inquired if I was interested in becoming a maintainer for the project. This PR adds me to the list of maintainers. I have read and understand the expectations of maintainers described in the `GOVERNANCE.md` file. Signed-off-by: Xiaoguang Sun <sunxiaoguang@zhihu.com>

@sunxiaoguang

* Title: Add @sunxiaoguang to MAINTAINERS.md My name is Sun Xiaoguang from Zhihu, where I help make a BigTable like system focusd on OLTP that is using TiKV. I've been contributing to TiKV and the library ecosystem for around a year now. I first touched the TiKV codebase since around March 2018. As part of my involvement with the project I've contributed several improvements to the TiKV Project: * [Added raw batch put/get/delete/scan](pingcap/kvproto#244) * [Changed `get_region` and `get_region_info` to use a common implementation](#3521) * [Print help message when starting tikv-ctl without argument](#3531) * [Clean up unused #[allow] directives](#3553) I also am the first and primary author of the [TiKV Rust Client](https://github.com/tikv/client-rust). You can see related PRs for that here: * [TiKV Rust Client RFC](tikv/rfcs#7) * [The initial version of Raw KV Implementation](tikv/client-rust#14) * [Change `raw::Client::get` to return `Option<Value>`](tikv/client-rust#24) * [Remove cf and batch_scan from `example/raw.rs`](tikv/client-rust#21) I also made the first PR to the mock TiKV project: [A basic implementation of mock TiKV API surface](tikv/mock-tikv#1) As part of my involvement, the TiKV team inquired if I was interested in becoming a maintainer for the project. This PR adds me to the list of maintainers. I have read and understand the expectations of maintainers described in the `GOVERNANCE.md` file. Signed-off-by: Xiaoguang Sun <sunxiaoguang@zhihu.com>

@sunxiaoguang

* Title: Add @sunxiaoguang to MAINTAINERS.md My name is Sun Xiaoguang from Zhihu, where I help make a BigTable like system focusd on OLTP that is using TiKV. I've been contributing to TiKV and the library ecosystem for around a year now. I first touched the TiKV codebase since around March 2018. As part of my involvement with the project I've contributed several improvements to the TiKV Project: * [Added raw batch put/get/delete/scan](pingcap/kvproto#244) * [Changed `get_region` and `get_region_info` to use a common implementation](tikv#3521) * [Print help message when starting tikv-ctl without argument](tikv#3531) * [Clean up unused #[allow] directives](tikv#3553) I also am the first and primary author of the [TiKV Rust Client](https://github.com/tikv/client-rust). You can see related PRs for that here: * [TiKV Rust Client RFC](tikv/rfcs#7) * [The initial version of Raw KV Implementation](tikv/client-rust#14) * [Change `raw::Client::get` to return `Option<Value>`](tikv/client-rust#24) * [Remove cf and batch_scan from `example/raw.rs`](tikv/client-rust#21) I also made the first PR to the mock TiKV project: [A basic implementation of mock TiKV API surface](tikv/mock-tikv#1) As part of my involvement, the TiKV team inquired if I was interested in becoming a maintainer for the project. This PR adds me to the list of maintainers. I have read and understand the expectations of maintainers described in the `GOVERNANCE.md` file. Signed-off-by: Xiaoguang Sun <sunxiaoguang@zhihu.com>

zhangjinpeng87 · 2021-05-31T08:47:56Z

@sunxiaoguang Seems this RFC is out-of-date with existing tikv/rust-client, would you mind to update it or just clost it?

sunxiaoguang force-pushed the tikv-client-rust branch from 96bd8bd to cf0cd50 Compare October 25, 2018 09:57

solotzg reviewed Oct 25, 2018

View reviewed changes

Comment thread text/2018-10-25-tikv-client-rust.md Outdated

TiKV Rust Client

7419c9b

Signed-off-by: Xiaoguang Sun <sunxiaoguang@zhihu.com>

sunxiaoguang force-pushed the tikv-client-rust branch from cf0cd50 to 7419c9b Compare October 25, 2018 10:24

siddontang reviewed Oct 30, 2018

View reviewed changes

Comment thread text/2018-10-25-tikv-client-rust.md Outdated

lilin90 reviewed Oct 31, 2018

View reviewed changes

Comment thread text/2018-10-25-tikv-client-rust.md Outdated

Comment thread text/2018-10-25-tikv-client-rust.md Outdated

Comment thread text/2018-10-25-tikv-client-rust.md Outdated

Comment thread text/2018-10-25-tikv-client-rust.md Outdated

Add more about API usage

64aad0b

Signed-off-by: Xiaoguang Sun <sunxiaoguang@zhihu.com>

Hoverbear reviewed Oct 31, 2018

View reviewed changes

Comment thread text/2018-10-25-tikv-client-rust.md Outdated

Hoverbear reviewed Oct 31, 2018

View reviewed changes

Comment thread text/2018-10-25-tikv-client-rust.md Outdated

Hoverbear reviewed Oct 31, 2018

View reviewed changes

Comment thread text/2018-10-25-tikv-client-rust.md Outdated

Hoverbear reviewed Oct 31, 2018

View reviewed changes

Comment thread text/2018-10-25-tikv-client-rust.md Outdated

Hoverbear reviewed Oct 31, 2018

View reviewed changes

Comment thread text/2018-10-25-tikv-client-rust.md Outdated

Hoverbear reviewed Oct 31, 2018

View reviewed changes

Comment thread text/2018-10-25-tikv-client-rust.md Outdated

Hoverbear reviewed Oct 31, 2018

View reviewed changes

Comment thread text/2018-10-25-tikv-client-rust.md Outdated

Hoverbear reviewed Oct 31, 2018

View reviewed changes

Comment thread text/2018-10-25-tikv-client-rust.md Outdated

Hoverbear reviewed Oct 31, 2018

View reviewed changes

Comment thread text/2018-10-25-tikv-client-rust.md Outdated

Hoverbear reviewed Oct 31, 2018

View reviewed changes

Comment thread text/2018-10-25-tikv-client-rust.md Outdated

Hoverbear reviewed Oct 31, 2018

View reviewed changes

Comment thread text/2018-10-25-tikv-client-rust.md Outdated

Hoverbear reviewed Oct 31, 2018

View reviewed changes

Comment thread text/2018-10-25-tikv-client-rust.md Outdated

rleungx reviewed Nov 2, 2018

View reviewed changes

Comment thread text/2018-10-25-tikv-client-rust.md Outdated

Comment thread text/2018-10-25-tikv-client-rust.md Outdated

Fix some gramma mistakes

57cc178

Signed-off-by: Xiaoguang Sun <sunxiaoguang@zhihu.com>

lilin90 reviewed Nov 2, 2018

View reviewed changes

Comment thread text/2018-10-25-tikv-client-rust.md Outdated

Comment thread text/2018-10-25-tikv-client-rust.md Outdated

Fix indentation

e82ac4e

Signed-off-by: Xiaoguang Sun <sunxiaoguang@zhihu.com>

sunxiaoguang force-pushed the tikv-client-rust branch from a48509c to e82ac4e Compare November 2, 2018 13:37

sunxiaoguang added 3 commits November 5, 2018 22:43

Fixed a typo

43ed161

Signed-off-by: Xiaoguang Sun <sunxiaoguang@zhihu.com>

Do not move key for get, scan and delete methods

5368649

Signed-off-by: Xiaoguang Sun <sunxiaoguang@zhihu.com>

Remove KeyRange and use RangeBounds trait instead

0cfcaff

Signed-off-by: Xiaoguang Sun <sunxiaoguang@zhihu.com>

gregwebs reviewed Nov 12, 2018

View reviewed changes

Comment thread text/2018-10-25-tikv-client-rust.md Outdated

Merge branch 'master' into tikv-client-rust

e692e80

Hoverbear assigned sunxiaoguang and Hoverbear Dec 21, 2018

Hoverbear and others added 2 commits February 21, 2019 11:50

Fix lints

1a7c67f

Signed-off-by: Ana Hobden <operator@hoverbear.org>

Hoverbear force-pushed the tikv-client-rust branch 3 times, most recently from e857c87 to 041fe9f Compare February 21, 2019 19:53

breezewish and others added 3 commits February 21, 2019 11:53

Unified Log Format RFC (tikv#18)

aa950ff

* unified log format Signed-off-by: Wenxuan Shi <hi@breeswish.org> Signed-off-by: Ana Hobden <operator@hoverbear.org>

RFC: PD Simulator (tikv#20)

5eb89c3

* introduce PD simulator Signed-off-by: Ryan Leung <rleungx@gmail.com> Signed-off-by: Ana Hobden <operator@hoverbear.org>

Update RFC to match code

252eb33

Signed-off-by: Ana Hobden <operator@hoverbear.org>

Hoverbear force-pushed the tikv-client-rust branch from 041fe9f to 252eb33 Compare February 21, 2019 19:54

Hoverbear added 3 commits February 21, 2019 11:54

Merge branch 'master' into tikv-client-rust

9d2e4c3

Fix lints

41d029d

Signed-off-by: Ana Hobden <operator@hoverbear.org>

Merge branch 'tikv-client-rust' of github.com:sunxiaoguang/rfcs into …

2c77911

…tikv-client-rust

Hoverbear mentioned this pull request Feb 26, 2019

TiKV Command Line RFC #21

Closed

sunxiaoguang mentioned this pull request Mar 19, 2019

Add @sunxiaoguang to MAINTAINERS.md tikv/tikv#4397

Merged

Hoverbear added 2 commits May 9, 2019 14:36

Merge branch 'master' into tikv-client-rust

bbb504c

Merge branch 'master' into tikv-client-rust

1ff37ef

Hoverbear removed their assignment Jul 8, 2020

Merge branch 'master' into tikv-client-rust

ddeaeea

Conversation

sunxiaoguang commented Oct 25, 2018 • edited by Hoverbear Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

siddontang commented Oct 30, 2018

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Hoverbear commented Oct 31, 2018

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Hoverbear commented Dec 20, 2018

Uh oh!

Hoverbear commented Jan 15, 2019

Uh oh!

Hoverbear commented Feb 21, 2019

Uh oh!

zhangjinpeng87 commented May 31, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

sunxiaoguang commented Oct 25, 2018 •

edited by Hoverbear

Loading