Conversation
Closed
sunxiaoguang
approved these changes
Dec 7, 2018
Member
sunxiaoguang
left a comment
sunxiaoguang
left a comment
There was a problem hiding this comment.
Since Edition 2018 is officially released, how about we merge this pull request now?
sticnarf
reviewed
Dec 7, 2018
sticnarf
reviewed
Dec 7, 2018
Signed-off-by: Hoverbear <operator@hoverbear.org>
Signed-off-by: Hoverbear <operator@hoverbear.org>
Signed-off-by: Hoverbear <operator@hoverbear.org>
Signed-off-by: Hoverbear <operator@hoverbear.org>
Signed-off-by: Hoverbear <operator@hoverbear.org>
Member
|
Can we merge this now? And I will be able to upgrade the code I'm working on to 2018 edition. |
Contributor
Author
|
Let's do it then. :) |
Member
Cool:) |
sunxiaoguang
pushed a commit
that referenced
this pull request
Jan 11, 2019
* Bump to 2018 edition. Signed-off-by: Hoverbear <operator@hoverbear.org> * Add toolchain Signed-off-by: Hoverbear <operator@hoverbear.org> * Fix examples Signed-off-by: Hoverbear <operator@hoverbear.org> * fmt and lint Signed-off-by: Hoverbear <operator@hoverbear.org> * We can use stable now Signed-off-by: Hoverbear <operator@hoverbear.org> Signed-off-by: Xiaoguang Sun <sunxiaoguang@zhihu.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows from tikv/rfcs#7.